Bug 152850 - FTL B3 PutById should do exceptions
Summary: FTL B3 PutById should do exceptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 151686
  Show dependency tree / graph
 
Reported: 2016-01-07 13:29 PST by Filip Pizlo
Modified: 2016-01-07 16:01 PST (History)
6 users (show)

See Also:

Attachments
the patch (17.35 KB, patch)
2016-01-07 14:11 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (16.78 KB, patch)
2016-01-07 14:11 PST, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-07 13:29:08 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-07 14:11:30 PST 
Created attachment 268486 [details]
the patch
Comment 2 Filip Pizlo 2016-01-07 14:11:58 PST 
Created attachment 268487 [details]
the patch
Comment 3 Saam Barati 2016-01-07 14:13:13 PST 
Comment on attachment 268487 [details]
the patch

r=me
Comment 4 Filip Pizlo 2016-01-07 15:00:36 PST 
Landed in http://trac.webkit.org/changeset/194730
Comment 5 Ryan Haddad 2016-01-07 15:43:31 PST 
** The following JSC stress test failures have been introduced:
	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.default-ftl
	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager
	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no-cjit
	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit-no-inline-validate
	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit-validate

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/2311/steps/jscore-test/logs/stdio>
Comment 6 Filip Pizlo 2016-01-07 15:54:14 PST 
(In reply to comment #5)
> ** The following JSC stress test failures have been introduced:
> 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.default-ftl
> 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager
> 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-
> no-cjit
> 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit-
> no-inline-validate
> 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit-
> validate
> 
> <https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/2311/steps/jscore-
> test/logs/stdio>

I'm on it.
Comment 7 Filip Pizlo 2016-01-07 16:01:48 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > ** The following JSC stress test failures have been introduced:
> > 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.default-ftl
> > 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager
> > 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-
> > no-cjit
> > 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit-
> > no-inline-validate
> > 	stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-no-cjit-
> > validate
> > 
> > <https://build.webkit.org/builders/
> > Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/2311/steps/jscore-
> > test/logs/stdio>
> 
> I'm on it.

Fixed in http://trac.webkit.org/changeset/194740.