Bug 152840 - [JSC] When resolving Stack arguments, use addressing from SP when addressing from FP is invalid
Summary: [JSC] When resolving Stack arguments, use addressing from SP when addressing ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on: 152864
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-07 11:20 PST by Benjamin Poulain
Modified: 2016-01-11 08:21 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.41 KB, patch)
2016-01-07 11:27 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch for landing (4.33 KB, patch)
2016-01-11 07:23 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-01-07 11:20:30 PST
[JSC] When resolving Stack arguments, use addressing from SP when addressing from FP is invalid
Comment 1 Benjamin Poulain 2016-01-07 11:27:39 PST
Created attachment 268469 [details]
Patch
Comment 2 Mark Lam 2016-01-07 11:32:09 PST
Comment on attachment 268469 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2016-01-07 13:16:25 PST
Comment on attachment 268469 [details]
Patch

Clearing flags on attachment: 268469

Committed r194714: <http://trac.webkit.org/changeset/194714>
Comment 4 WebKit Commit Bot 2016-01-07 13:16:27 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Filip Pizlo 2016-01-07 14:38:22 PST
This broke many JSC tests when running with FTL B3.  Please run JSC tests with FTL B3 turned on before landing B3 changes.
Comment 6 WebKit Commit Bot 2016-01-07 14:41:02 PST
Re-opened since this is blocked by bug 152864
Comment 7 Benjamin Poulain 2016-01-11 07:23:49 PST
Created attachment 268686 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2016-01-11 08:21:41 PST
Comment on attachment 268686 [details]
Patch for landing

Clearing flags on attachment: 268686

Committed r194850: <http://trac.webkit.org/changeset/194850>
Comment 9 WebKit Commit Bot 2016-01-11 08:21:45 PST
All reviewed patches have been landed.  Closing bug.