Bug 152838 – [mips] GPRInfo::toArgumentRegister missing

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Konstantin Tokarev]

Added missing GPRInfo::toArgumentRegister implementation for MIPS

[Konstantin Tokarev]

Created attachment 268467 [details]
Patch

[Michael Saboff]

Comment on attachment 268467 [details]
Patch

We do not have plans to implement passing arguments in registers for 32 bit platforms.  Therefore this is not needed.

[Konstantin Tokarev]

GPRInfo::toArgumentRegister is used at Source/JavaScriptCore/jit/CCallHelpers.h:58 which currently breaks compilation on MIPS

BTW, MIPS32 has 32 GPRs so it would be the right thing to pass arguments via registers.

[Michael Saboff]

Comment on attachment 268467 [details]
Patch

r=me.  Forgot that this is used in other areas.

[Michael Saboff]

(In reply to comment #3)
> GPRInfo::toArgumentRegister is used at
> Source/JavaScriptCore/jit/CCallHelpers.h:58 which currently breaks
> compilation on MIPS
> 
> BTW, MIPS32 has 32 GPRs so it would be the right thing to pass arguments via
> registers.

With only 4 argument registers, it still doesn't make sense to pass arguments in registers.  Effectively this would only allow for "this" to be passed.  a0 would have the callee, a1 would have the arg count, and a2/a3 would have the tag and payload for this.  Even if we didn't pass the callee and arg count in registers, that would only give this and arg1.

[WebKit Commit Bot]

Comment on attachment 268467 [details]
Patch

Clearing flags on attachment: 268467

Committed r194709: <http://trac.webkit.org/changeset/194709>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.