Details in the coming patch.
Created attachment 268457 [details] proposed fix.
Comment on attachment 268457 [details] proposed fix. This patch has passed the JSC tests on ARM64 and ARMv7. It's ready for a review.
Thanks for the review. Landed in r194707: <http://trac.webkit.org/r194707>.
Comment on attachment 268457 [details] proposed fix. View in context: https://bugs.webkit.org/attachment.cgi?id=268457&action=review r- > Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:548 > + or32(imm, memoryTempRegister, memoryTempRegister); > + store32(memoryTempRegister, address.m_ptr); You can't store32 with a source of memoryTempRegister as it will be needed to materialize the address. You could change this to: or32(imm, memoryTempRegister, getCachedDataTempRegisterIDAndInvalidate()); store32(dataTempRegister, address.m_ptr); Also, please add an ASSERT() to template<int datasize> store() that the src register cannot be memoryTempRegister.
Created attachment 268473 [details] follow up fix for ARM64.
Comment on attachment 268473 [details] follow up fix for ARM64. r=me
Thanks for the review. Follow up fix landed in r194711: <http://trac.webkit.org/r194711>.