Bug 152788 - REGRESSION(r192138): [GTK] imported/mozilla/svg/filter-scaled-02.html is failing
Summary: REGRESSION(r192138): [GTK] imported/mozilla/svg/filter-scaled-02.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-06 09:54 PST by Carlos Alberto Lopez Perez
Modified: 2020-06-19 00:34 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2016-01-06 09:54:18 PST 
Revision r192138 <http://trac.webkit.org/r192138> has caused the following 6 new failures:

Regressions: Unexpected image-only failures (6)
  imported/mozilla/svg/filter-scaled-02.html [ ImageOnlyFailure ]
  imported/mozilla/svg/image/image-filter-01.svg [ ImageOnlyFailure ]
  svg/filters/color-space-conversion.svg [ ImageOnlyFailure ]
  svg/filters/container-with-filters.svg [ ImageOnlyFailure ]
  svg/filters/feComposite-background-rect-control-operators.svg [ ImageOnlyFailure ]
  svg/filters/feDisplacementMap-filterUnits.svg [ ImageOnlyFailure ]


I have tested to revert locally r192138 on top of r194637 and the above 6 tests pass again.

The diffs are the following:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r194637%20%2812965%29/imported/mozilla/svg/filter-scaled-02-diffs.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r194637%20%2812965%29/imported/mozilla/svg/image/image-filter-01-diffs.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r194637%20%2812965%29/svg/filters/color-space-conversion-diffs.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r194637%20%2812965%29/svg/filters/container-with-filters-diffs.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r194637%20%2812965%29/svg/filters/feComposite-background-rect-control-operators-diffs.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r194637%20%2812965%29/svg/filters/feDisplacementMap-filterUnits-diffs.html


Note: imported/mozilla/svg/image/image-filter-01.svg that is marked as failing on the general TestExpectations because of bug 139282 was passing on the GTK platform before r192138 (it was marked as passing on the GTK TestExpectations).
Comment 1 Simon Fraser (smfr) 2016-01-06 10:35:40 PST 
Why did GTK EWS go green on the original patch? Does it not run tests?
Comment 2 Carlos Alberto Lopez Perez 2016-01-06 10:55:12 PST 
(In reply to comment #1)
> Why did GTK EWS go green on the original patch? Does it not run tests?

It does not run tests, the GTK EWS only tests if the build passes or not.
Comment 3 Michael Catanzaro 2017-12-22 15:27:51 PST 
Simon fixed all of these tests (and *many* more) in r225797 "Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace".

Exception: imported/mozilla/svg/filter-scaled-02.html is still broken, so we cannot close this bug yet.
Comment 4 Simon Fraser (smfr) 2017-12-22 18:41:51 PST 
Nice.
Comment 5 Diego Pino 2020-06-19 00:33:03 PDT 
The test(s) filed under this bug have been consistently passing for the last 4000 revisions. Marking bug as fixed.

Committed r263254: <https://trac.webkit.org/changeset/263254>
Comment 6 Radar WebKit Bug Importer 2020-06-19 00:34:26 PDT 
<rdar://problem/64522506>