Bug 152781 - [mips] Fix bug in or32() implementation
Summary: [mips] Fix bug in or32() implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Brianceau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-06 02:31 PST by Julien Brianceau
Modified: 2016-01-06 12:58 PST (History)
6 users (show)

See Also:

Attachments
Fix or32() mips implementation in macro assembler (1.25 KB, patch)
2016-01-06 02:41 PST, Julien Brianceau 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2016-01-06 02:31:14 PST 
In mips macro assembler, the or32(TrustedImm32, RegisterID, RegisterID) implementation is buggy when used with a null immediate
Comment 1 Julien Brianceau 2016-01-06 02:41:03 PST 
Created attachment 268363 [details]
Fix or32() mips implementation in macro assembler

Note: already contributed in qtwekbit http://code.qt.io/cgit/qt/qtwebkit.git/commit/?id=0546c8656a3728bf4375da39027e096beba4f111
Comment 2 Michael Saboff 2016-01-06 09:47:19 PST 
Comment on attachment 268363 [details]
Fix or32() mips implementation in macro assembler

r=me
Comment 3 Julien Brianceau 2016-01-06 12:58:13 PST 
Manually committed r194640: http://trac.webkit.org/changeset/194640