Bug 152774 – Support the ScrollOptions argument to programmatic scrolling APIs

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: DOM

[Simon Fraser (smfr)]

WebKit should support the ScrollOptions dictionary described in https://drafts.csswg.org/cssom-view/#scrolling

This involves new API on Element, processing the ScrollOptions, and triggering smooth scrolling.

[Simon Fraser (smfr)]

Created attachment 268373 [details]
WIP

[WebKit Commit Bot]

Attachment 268373 [details] did not pass style-queue:


ERROR: Source/WebCore/page/DOMWindow.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 268373 [details]
WIP

Attachment 268373 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/658417

New failing tests:
fast/dom/Window/window-scroll-arguments.html

[Build Bot]

Created attachment 268381 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 268373 [details]
WIP

Attachment 268373 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/658419

New failing tests:
fast/dom/Window/window-scroll-arguments.html

[Build Bot]

Created attachment 268382 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 268373 [details]
WIP

Attachment 268373 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/658428

New failing tests:
fast/dom/Window/window-scroll-arguments.html

[Build Bot]

Created attachment 268383 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

WebKit currently supports window.scrollTo() with one argument. We need to make scrollTo(<number>) throw, and require that the single-argument version is getting an Object argument (as FF and Blink do). Not sure how do that in IDL.

[Sam Weinig]

(In reply to comment #9)
> WebKit currently supports window.scrollTo() with one argument. We need to
> make scrollTo(<number>) throw, and require that the single-argument version
> is getting an Object argument (as FF and Blink do). Not sure how do that in
> IDL.

Probably something like this:

    void scrollTo(long x, long y);
    void scrollTo(optional Dictionary options);

Though, we may want to change to "unrestricted double" as well.

[Simon Fraser (smfr)]

This also shows that there's some combat risk with this change, but since Chrome and FF both agree on the new behavior, it's probably low.

[Radar WebKit Bug Importer]

<rdar://problem/24102997>

[Simon Fraser (smfr)]

This has been implemented via bindings changes etc.