RESOLVED FIXED 152760
Progress towards implementing downloads with NetworkSession 
https://bugs.webkit.org/show_bug.cgi?id=152760
Summary Progress towards implementing downloads with NetworkSession
Alex Christensen
Reported 2016-01-05 15:02:12 PST
Progress towards implementing downloads with NetworkSession
Attachments
Patch (19.29 KB, patch)
2016-01-05 15:02 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (22.87 KB, patch)
2016-01-06 13:59 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (22.72 KB, patch)
2016-01-06 14:41 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (22.87 KB, patch)
2016-01-06 17:02 PST, Alex Christensen 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-01-05 15:02:34 PST
Created attachment 268329 [details] Patch
Alex Christensen
Comment 2 2016-01-05 15:03:10 PST
Comment on attachment 268329 [details] Patch This first patch doesn't do anything yet. I'll upload another one soon that is similar to this one.
Alex Christensen
Comment 3 2016-01-06 13:59:38 PST
Created attachment 268402 [details] Patch
Alex Christensen
Comment 4 2016-01-06 14:41:26 PST
Created attachment 268411 [details] Patch
Alex Christensen
Comment 5 2016-01-06 17:02:37 PST
Created attachment 268423 [details] Patch
Brady Eidson
Comment 6 2016-01-07 13:24:58 PST
Comment on attachment 268423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268423&action=review > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:97 > #if USE(NETWORK_SESSION) > - m_task->cancel(); > + if (m_task) > + m_task->cancel(); > #else > if (m_handle) > m_handle->cancel(); Seems like this was pre-existing, but it seems weird to cancel a load that doesn't have a task.
Alex Christensen
Comment 7 2016-01-07 13:29:14 PST
http://trac.webkit.org/changeset/194718
Note You need to log in before you can comment on or make changes to this bug.