Bug 152748 - Rename badly named JSC_timeout env var to JSCTEST_timeout.
Summary: Rename badly named JSC_timeout env var to JSCTEST_timeout.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on: 153204
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-05 12:26 PST by Mark Lam
Modified: 2016-01-18 04:27 PST (History)
2 users (show)

See Also:

Attachments
proposed patch. (3.86 KB, patch)
2016-01-05 12:30 PST, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-01-05 12:26:49 PST 
Now that we validate JSC options, the badly named JSC_timeout env var causes the bots to have a bad time.
Comment 1 Mark Lam 2016-01-05 12:30:47 PST 
Created attachment 268307 [details]
proposed patch.
Comment 2 Geoffrey Garen 2016-01-05 12:41:55 PST 
Comment on attachment 268307 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2016-01-05 12:57:54 PST 
Thanks for the review.  Landed in r194601: <http://trac.webkit.org/r194601>.
Comment 4 Csaba Osztrogonác 2016-01-18 03:10:43 PST 
(In reply to comment #0)
> Now that we validate JSC options, the badly named JSC_timeout env var causes
> the bots to have a bad time.

I don't understand this change at all. I can't find any
references to JSCTEST_timeout in the source code.

jsc still uses JSC_timeout environment variable. That's why we have 
many stucked jsc processes on the ARM64 Linux tester bot. I already
set JSC_timeout locally to avoid stucked processes. But we need a
proper fix, for example changing jsc behaviour too or rolling out
this patch.
Comment 5 Csaba Osztrogonác 2016-01-18 04:27:33 PST 
I got the goal of this change, and uploaded the fix in bug153204 .