Bug 152744 - FTL B3 should do In
Summary: FTL B3 should do In
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 151808
  Show dependency tree / graph
 
Reported: 2016-01-05 11:47 PST by Filip Pizlo
Modified: 2016-01-05 12:40 PST (History)
5 users (show)

See Also:

Attachments
the patch (6.21 KB, patch)
2016-01-05 11:49 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (5.63 KB, patch)
2016-01-05 11:49 PST, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
patch for landing (5.93 KB, patch)
2016-01-05 12:12 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-05 11:47:37 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-05 11:49:02 PST 
Created attachment 268299 [details]
the patch
Comment 2 Filip Pizlo 2016-01-05 11:49:56 PST 
Created attachment 268300 [details]
the patch
Comment 3 Filip Pizlo 2016-01-05 11:50:57 PST 
Comment on attachment 268300 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268300&action=review

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:-6099
> -        speculateObject(base, cell);

I'm removing this because it wasn't ever necessary to begin with.  I don't know why this was there.  I'm running extra tests to make sure I didn't break trunk since I'm also removing this in the LLVM case.
Comment 4 Michael Saboff 2016-01-05 11:52:44 PST 
Comment on attachment 268300 [details]
the patch

r=me
Comment 5 WebKit Commit Bot 2016-01-05 11:52:59 PST 
Attachment 268300 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6106:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6125:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6138:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Filip Pizlo 2016-01-05 12:12:10 PST 
Created attachment 268303 [details]
patch for landing
Comment 7 WebKit Commit Bot 2016-01-05 12:13:05 PST 
Attachment 268303 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6106:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6125:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6138:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2016-01-05 12:40:04 PST 
Landed in http://trac.webkit.org/changeset/194598