Bug 152742 - Adjust tile coverage with margin tiles, and tidy up the indicator
Summary: Adjust tile coverage with margin tiles, and tidy up the indicator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-05 11:26 PST by Simon Fraser (smfr)
Modified: 2016-01-05 14:10 PST (History)
4 users (show)

See Also:


Attachments
Patch (16.50 KB, patch)
2016-01-05 11:30 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.01 MB, application/zip)
2016-01-05 12:21 PST, Build Bot
no flags Details
Patch (23.06 KB, patch)
2016-01-05 14:00 PST, Simon Fraser (smfr)
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-01-05 11:26:45 PST
Adjust tile coverage with margin tiles, and tidy up the indicator
Comment 1 Simon Fraser (smfr) 2016-01-05 11:30:29 PST
Created attachment 268297 [details]
Patch
Comment 2 Beth Dakin 2016-01-05 11:49:25 PST
Comment on attachment 268297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268297&action=review

> Source/WebCore/platform/graphics/ca/TileController.cpp:-395
> -    coverageHorizontalSize += leftMarginWidth() + rightMarginWidth();

In cases where widthScale and heightScale are still 1, will removing this code prevent coverage for margin tiles?
Comment 3 Simon Fraser (smfr) 2016-01-05 11:53:18 PST
(In reply to comment #2)
> Comment on attachment 268297 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268297&action=review
> 
> > Source/WebCore/platform/graphics/ca/TileController.cpp:-395
> > -    coverageHorizontalSize += leftMarginWidth() + rightMarginWidth();
> 
> In cases where widthScale and heightScale are still 1, will removing this
> code prevent coverage for margin tiles?

Yes, but if you're not extending coverage for scrolling, I don't think you need to extend it to include margin tiles. Or is there some rubber banding case that would have issues?
Comment 4 Simon Fraser (smfr) 2016-01-05 11:59:38 PST
Comment on attachment 268297 [details]
Patch

This does actually cause a bug; rubber-banding on a page without extra tile coverage has missing margin tiles.
Comment 5 Build Bot 2016-01-05 12:21:01 PST
Comment on attachment 268297 [details]
Patch

Attachment 268297 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/654143

New failing tests:
tiled-drawing/simple-document-with-margin-tiles.html
Comment 6 Build Bot 2016-01-05 12:21:06 PST
Created attachment 268304 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Simon Fraser (smfr) 2016-01-05 14:00:52 PST
Created attachment 268321 [details]
Patch
Comment 8 Simon Fraser (smfr) 2016-01-05 14:10:07 PST
https://trac.webkit.org/r194607