Adjust tile coverage with margin tiles, and tidy up the indicator
Created attachment 268297 [details] Patch
Comment on attachment 268297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268297&action=review > Source/WebCore/platform/graphics/ca/TileController.cpp:-395 > - coverageHorizontalSize += leftMarginWidth() + rightMarginWidth(); In cases where widthScale and heightScale are still 1, will removing this code prevent coverage for margin tiles?
(In reply to comment #2) > Comment on attachment 268297 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268297&action=review > > > Source/WebCore/platform/graphics/ca/TileController.cpp:-395 > > - coverageHorizontalSize += leftMarginWidth() + rightMarginWidth(); > > In cases where widthScale and heightScale are still 1, will removing this > code prevent coverage for margin tiles? Yes, but if you're not extending coverage for scrolling, I don't think you need to extend it to include margin tiles. Or is there some rubber banding case that would have issues?
Comment on attachment 268297 [details] Patch This does actually cause a bug; rubber-banding on a page without extra tile coverage has missing margin tiles.
Comment on attachment 268297 [details] Patch Attachment 268297 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/654143 New failing tests: tiled-drawing/simple-document-with-margin-tiles.html
Created attachment 268304 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 268321 [details] Patch
https://trac.webkit.org/r194607