Bug 152735 - Modern IDB: Error message updates for two failing tests
Summary: Modern IDB: Error message updates for two failing tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 150882
  Show dependency tree / graph
 
Reported: 2016-01-05 10:27 PST by Brady Eidson
Modified: 2016-01-05 11:57 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (58.03 KB, patch)
2016-01-05 11:27 PST, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-05 10:27:34 PST 
Modern IDB: Error message updates for two failing tests

storage/indexeddb/deleted-objects.html
storage/indexeddb/keypath-basics.html

Slight behavior changes, too, but progressions.
Comment 1 Brady Eidson 2016-01-05 11:27:38 PST 
Created attachment 268296 [details]
Patch v1
Comment 2 Alex Christensen 2016-01-05 11:36:35 PST 
Comment on attachment 268296 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=268296&action=review

r=me

> LayoutTests/storage/indexeddb/resources/keypath-basics.js:16
> -
> +    

:(

> LayoutTests/storage/indexeddb/resources/keypath-basics.js:-19
> -        { keyPath: "null", storeExpected: "null", indexExpected: "'null'" },
> -        { keyPath: "undefined", storeExpected: "null", indexExpected: "'undefined'" },

These have a new, more-modern-spec-complient behavior since the tests were written, right?  It's tested below.  Does WK2 still pass?
Comment 3 Brady Eidson 2016-01-05 11:41:41 PST 
(In reply to comment #2)
> Comment on attachment 268296 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268296&action=review
> 
> r=me
> 
> > LayoutTests/storage/indexeddb/resources/keypath-basics.js:16
> > -
> > +    
> 
> :(
> 
> > LayoutTests/storage/indexeddb/resources/keypath-basics.js:-19
> > -        { keyPath: "null", storeExpected: "null", indexExpected: "'null'" },
> > -        { keyPath: "undefined", storeExpected: "null", indexExpected: "'undefined'" },
> 
> These have a new, more-modern-spec-complient behavior since the tests were
> written, right?  It's tested below.  Does WK2 still pass?

Yes, and yes.
Comment 4 Brady Eidson 2016-01-05 11:57:42 PST 
https://trac.webkit.org/changeset/194595