WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
152726
Web Inspector: Make creating new rules in the Styles sidebar simpler
https://bugs.webkit.org/show_bug.cgi?id=152726
Summary
Web Inspector: Make creating new rules in the Styles sidebar simpler
Devin Rousso
Reported
2016-01-04 21:12:27 PST
Instead of creating a new rule (and therefore section/tree-item) each time the user clicks the "Add Rule" button, look to see if there are existing rules that have the same selector and focus/select the first rule that doesn't have any properties (if there are none, then create the new rule like normal). This should also apply to the context menu item functions (like creating ::before/::after).
Attachments
Patch
(26.44 KB, patch)
2016-01-04 21:29 PST
,
Devin Rousso
timothy
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Patch
(25.86 KB, patch)
2016-01-07 13:05 PST
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-01-04 21:12:41 PST
<
rdar://problem/24052188
>
Devin Rousso
Comment 2
2016-01-04 21:29:47 PST
Created
attachment 268265
[details]
Patch
WebKit Commit Bot
Comment 3
2016-01-07 11:41:33 PST
Comment on
attachment 268265
[details]
Patch Rejecting
attachment 268265
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 268265, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: mothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Parsed 10 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Original content of Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js mismatches at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 283. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.webkit.org/results/663408
Devin Rousso
Comment 4
2016-01-07 13:05:24 PST
Created
attachment 268477
[details]
Patch Horray for localizedStrings.js XD XD
WebKit Commit Bot
Comment 5
2016-01-07 13:28:06 PST
Comment on
attachment 268477
[details]
Patch Clearing flags on attachment: 268477 Committed
r194717
: <
http://trac.webkit.org/changeset/194717
>
WebKit Commit Bot
Comment 6
2016-01-07 13:28:09 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug