RESOLVED FIXED 152718
gtest should use the same SDK as other projects 
https://bugs.webkit.org/show_bug.cgi?id=152718
Summary gtest should use the same SDK as other projects
Alexey Proskuryakov
Reported 2016-01-04 15:58:01 PST
gtest's xcconfig files use USE_INTERNAL_SDK, but never define it. rdar://problem/23566856
Attachments
proposed fix (3.09 KB, patch)
2016-01-04 16:16 PST, Alexey Proskuryakov 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-01-04 16:16:24 PST
Created attachment 268245 [details] proposed fix
Alex Christensen
Comment 2 2016-01-04 22:58:22 PST
Comment on attachment 268245 [details] proposed fix Adding the definition of USE_INTERNAL_SDK looks good. r=me Why are you duplicating the use of it to DebugProject and ReleaseProject? They both include General.xcconfig. This seems unnecessary.
Alexey Proskuryakov
Comment 3 2016-01-04 23:34:13 PST
I did it to match other projects, which have this snippet in DebugRelease.xcconfig (so that it doesn't affect production builds). It is possible to avoid duplication, but at the cost of doing things differently, which seems likely to cause confusion again in the future.
Alexey Proskuryakov
Comment 4 2016-01-05 09:15:13 PST
Committed http://trac.webkit.org/r194585
Note You need to log in before you can comment on or make changes to this bug.