Bug 152712 - Hardware keyboard key-commands stop responding when viewing PDFs
Summary: Hardware keyboard key-commands stop responding when viewing PDFs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-04 13:26 PST by Tim Horton
Modified: 2016-01-04 14:42 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.99 KB, patch)
2016-01-04 13:27 PST, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-01-04 13:26:46 PST 
Hardware keyboard key-commands stop responding when viewing PDFs
Comment 1 Tim Horton 2016-01-04 13:27:00 PST 
Created attachment 268229 [details]
Patch
Comment 2 mitz 2016-01-04 13:30:39 PST 
Comment on attachment 268229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268229&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:793
> +    return [[self _currentContentView] becomeFirstResponder] || [super becomeFirstResponder];

Can’t use a dot here?
Comment 3 Tim Horton 2016-01-04 14:42:51 PST 
http://trac.webkit.org/changeset/194557