Bug 152709 - FTL B3 should do all of the non-bitop binary snippets
Summary: FTL B3 should do all of the non-bitop binary snippets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 152668
  Show dependency treegraph
 
Reported: 2016-01-04 12:55 PST by Filip Pizlo
Modified: 2016-01-04 13:34 PST (History)
5 users (show)

See Also:


Attachments
the patch (6.66 KB, patch)
2016-01-04 13:07 PST, Filip Pizlo
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-04 12:55:16 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-04 13:07:46 PST
Created attachment 268226 [details]
the patch
Comment 2 Mark Lam 2016-01-04 13:12:28 PST
Comment on attachment 268226 [details]
the patch

I think these tests are already covered by the op_mul.js, op_div.js, op_add.js stress tests.  If there are missing operand value cases, you can just add the values to those tests.
Comment 3 Mark Lam 2016-01-04 13:31:19 PST
(In reply to comment #2)
> Comment on attachment 268226 [details]
> the patch
> 
> I think these tests are already covered by the op_mul.js, op_div.js,
> op_add.js stress tests.  If there are missing operand value cases, you can
> just add the values to those tests.

Talked to Fil offline.  He pointed out that these tests run for 100000 iterations and are targetted towards the FTL, whereas the pre-existing tests only iterate up to 10000.  Rather than making the comprehensive tests wait for 100000 iterations, I'm ok with having these additional small test subsets just for the ftl.
Comment 4 Filip Pizlo 2016-01-04 13:34:11 PST
Landed in http://trac.webkit.org/changeset/194553