Bug 152692 - Web Inspector: Add basic Animation section to Visual Sidebar
Summary: Web Inspector: Add basic Animation section to Visual Sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 172579
  Show dependency treegraph
 
Reported: 2016-01-04 09:49 PST by Devin Rousso
Modified: 2017-05-24 22:07 PDT (History)
9 users (show)

See Also:


Attachments
Patch (12.20 KB, patch)
2016-01-04 10:48 PST, Devin Rousso
timothy: review+
Details | Formatted Diff | Diff
Patch (12.64 KB, patch)
2016-01-06 14:46 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-01-04 09:49:48 PST
We currently do not have the capability in Web Inspector to autocomplete the list of keyframes on the page, but the rest of the animation properties are all keyword based, so they can be added.
Comment 1 Radar WebKit Bug Importer 2016-01-04 09:49:58 PST
<rdar://problem/24042244>
Comment 2 Devin Rousso 2016-01-04 10:48:40 PST
Created attachment 268205 [details]
Patch
Comment 3 Joseph Pecoraro 2016-01-04 20:55:28 PST
Comment on attachment 268205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268205&action=review

> Source/WebInspectorUI/UserInterface/Images/AnimationPlayStatePaused.svg:3
> +<!-- Copyright © 2016 Apple Inc. All rights reserved. -->
> +<!-- Copyright © 2016 Devin Rousso <dcrousso+webkit@gmail.com>. All rights reserved. -->

Both of these needed? Or just yours?
Comment 4 Devin Rousso 2016-01-04 21:08:06 PST
Comment on attachment 268205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268205&action=review

>> Source/WebInspectorUI/UserInterface/Images/AnimationPlayStatePaused.svg:3
>> +<!-- Copyright © 2016 Devin Rousso <dcrousso+webkit@gmail.com>. All rights reserved. -->
> 
> Both of these needed? Or just yours?

I put both because this icon was almost a direct copy of UserInterface/Images/Pause.svg
Comment 5 Timothy Hatcher 2016-01-06 10:22:01 PST
Comment on attachment 268205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268205&action=review

> Source/WebInspectorUI/UserInterface/Images/AnimationPlayStatePaused.svg:2
> +<!-- Copyright © 2016 Apple Inc. All rights reserved. -->

This would be 2015 still.

>>> Source/WebInspectorUI/UserInterface/Images/AnimationPlayStatePaused.svg:3
>>> +<!-- Copyright © 2016 Devin Rousso <dcrousso+webkit@gmail.com>. All rights reserved. -->
>> 
>> Both of these needed? Or just yours?
> 
> I put both because this icon was almost a direct copy of UserInterface/Images/Pause.svg

You should add your copyright line to the license header in copy-user-interface-resources.pl.
Comment 6 Devin Rousso 2016-01-06 14:46:24 PST
Created attachment 268415 [details]
Patch
Comment 7 WebKit Commit Bot 2016-01-06 15:46:39 PST
Comment on attachment 268415 [details]
Patch

Clearing flags on attachment: 268415

Committed r194673: <http://trac.webkit.org/changeset/194673>
Comment 8 WebKit Commit Bot 2016-01-06 15:46:43 PST
All reviewed patches have been landed.  Closing bug.