To pass streams-api tests, we need to use service_worker_test() routine defined in a file within web-platform-tests/services-workers. It is just best to activate import of the whole web-platform-tests/services-workers while marking all tests as skipped so as to ensure we have support for that routine.
Created attachment 268184 [details] Patch
(In reply to comment #1) > Created attachment 268184 [details] > Patch As it is now, it is not possible to mark a top-folder as [ Skip ] and a sub-folder as [ Pass ] within ImportExpectations This is the simplest solution to keep having web-platform-tests/services-workers/resources folder while reimporting tests using bug 152685 new option.
Comment on attachment 268184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268184&action=review > LayoutTests/imported/w3c/ChangeLog:8 > + Importing service-workers tests. From briefly looking through this patch I am unclear what revision of <https://github.com/w3c/web-platform-tests.git> these tests represent. Are they from the same revision as the tests in the patch on bug #151984 , 5932fd48d519a83b4cca6ed69778547a4fdfc5ae? Please add a remark to this ChangeLog entry to clarify the revision of these tests. > LayoutTests/imported/w3c/resources/ImportExpectations:205 > +#web-platform-tests/service-workers [ Pass ] Will we actually run these tests? I mean this line is prefixed with a '#', which is interpreted as a comment if this file is parsed similar to a TestExpectations file. > LayoutTests/imported/w3c/web-platform-tests/service-workers/stub-3.1.3-service-worker-state.html:76 > + I'm assuming this empty line was part of the original file. I've noticed that some of these files have such an empty line at the end of them.
> From briefly looking through this patch I am unclear what revision of > <https://github.com/w3c/web-platform-tests.git> these tests represent. Are > they from the same revision as the tests in the patch on bug #151984 , > 5932fd48d519a83b4cca6ed69778547a4fdfc5ae? Please add a remark to this > ChangeLog entry to clarify the revision of these tests. We should always use the same revision throughout web-platform-tests. In that particular case, the files have not changed, so it does not really matter. I will update the changelog to mention 5932fd48d519a83b4cca6ed69778547a4fdfc5ae. > > LayoutTests/imported/w3c/resources/ImportExpectations:205 > > +#web-platform-tests/service-workers [ Pass ] > > Will we actually run these tests? I mean this line is prefixed with a '#', > which is interpreted as a comment if this file is parsed similar to a > TestExpectations file. This line is not needed, it is some kind of documentation. "[ Pass ]" is misleading since we use those rules to do import or skip it. I will change that to "[ Import ]" > > LayoutTests/imported/w3c/web-platform-tests/service-workers/stub-3.1.3-service-worker-state.html:76 > > + > > I'm assuming this empty line was part of the original file. I've noticed > that some of these files have such an empty line at the end of them. Right.
Created attachment 268273 [details] Patch for landing
Comment on attachment 268273 [details] Patch for landing Clearing flags on attachment: 268273 Committed r194582: <http://trac.webkit.org/changeset/194582>
All reviewed patches have been landed. Closing bug.