Bug 152677 – [GTK] Fix -Wpessimizing-move warnings after switch to WTFMove

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Now that we have switched from WTF::move to the macro WTFMove, we've triggered some good clang warnings that our use of WTF::move was hiding.

[1015/3230] Building CXX object Source...r/platform/glib/KeyedDecoderGlib.cpp.o
../../Source/WebCore/platform/glib/KeyedDecoderGlib.cpp:61:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move<WTF::CheckMoveParameter>(dictionary);
           ^
../../Source/WebCore/platform/glib/KeyedDecoderGlib.cpp:61:12: note: remove std::move call here
    return std::move<WTF::CheckMoveParameter>(dictionary);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~          ~
1 warning generated.
[1038/3230] Building CXX object Source...atform/graphics/egl/GLContextEGL.cpp.o
../../Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:212:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move<WTF::CheckMoveParameter>(context);
           ^
../../Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:212:12: note: remove std::move call here
    return std::move<WTF::CheckMoveParameter>(context);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~       ~
1 warning generated.
[1046/3230] Building CXX object Source...atform/graphics/glx/GLContextGLX.cpp.o
../../Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:139:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move<WTF::CheckMoveParameter>(context);
           ^
../../Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:139:12: note: remove std::move call here
    return std::move<WTF::CheckMoveParameter>(context);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~       ~
1 warning generated.

[Michael Catanzaro]

Created attachment 268159 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 268159 [details]
Patch

Clearing flags on attachment: 268159

Committed r194527: <http://trac.webkit.org/changeset/194527>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.