WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
152670
Update data reporting and analysis
https://bugs.webkit.org/show_bug.cgi?id=152670
Summary
Update data reporting and analysis
Jon Lee
Reported
2016-01-03 15:13:11 PST
Avoid doing a lot of processing during the benchmark itself. Also show raw data on top of the filtered data.
Attachments
Patch
(60.51 KB, patch)
2016-01-03 18:04 PST
,
Jon Lee
simon.fraser
: review+
Details
Formatted Diff
Diff
1. Avoid processing the data through the Experiment while the test is running.
(21.88 KB, patch)
2016-01-03 18:10 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
2. Refactor how Animator does its recording.
(14.98 KB, patch)
2016-01-03 18:10 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
3. Producing the JSON can take a while with all of the data.
(6.40 KB, patch)
2016-01-03 18:11 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
4. Show new graph data.
(29.27 KB, patch)
2016-01-03 18:11 PST
,
Jon Lee
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-01-03 15:13:25 PST
<
rdar://problem/24033996
>
Jon Lee
Comment 2
2016-01-03 18:04:23 PST
Created
attachment 268165
[details]
Patch
Jon Lee
Comment 3
2016-01-03 18:10:30 PST
Created
attachment 268166
[details]
1. Avoid processing the data through the Experiment while the test is running.
Jon Lee
Comment 4
2016-01-03 18:10:51 PST
Created
attachment 268167
[details]
2. Refactor how Animator does its recording.
Jon Lee
Comment 5
2016-01-03 18:11:14 PST
Created
attachment 268168
[details]
3. Producing the JSON can take a while with all of the data.
Jon Lee
Comment 6
2016-01-03 18:11:34 PST
Created
attachment 268169
[details]
4. Show new graph data.
Simon Fraser (smfr)
Comment 7
2016-01-03 18:22:01 PST
Comment on
attachment 268165
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=268165&action=review
> PerformanceTests/Animometer/resources/debug-runner/animometer.js:362 > + document.querySelector("#results-json button").remove();
Does .remove() work in all browsers we care about?
Jon Lee
Comment 8
2016-01-03 18:24:43 PST
(In reply to
comment #7
)
> Comment on
attachment 268165
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=268165&action=review
> > > PerformanceTests/Animometer/resources/debug-runner/animometer.js:362 > > + document.querySelector("#results-json button").remove(); > > Does .remove() work in all browsers we care about?
Yes.
Jon Lee
Comment 9
2016-01-03 18:37:35 PST
Committed
r194523
: <
http://trac.webkit.org/changeset/194523
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug