Bug 152670 - Update data reporting and analysis
Summary: Update data reporting and analysis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-03 15:13 PST by Jon Lee
Modified: 2016-01-03 18:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (60.51 KB, patch)
2016-01-03 18:04 PST, Jon Lee 		simon.fraser: review+
Details | Formatted Diff | Diff
1. Avoid processing the data through the Experiment while the test is running. (21.88 KB, patch)
2016-01-03 18:10 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
2. Refactor how Animator does its recording. (14.98 KB, patch)
2016-01-03 18:10 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
3. Producing the JSON can take a while with all of the data. (6.40 KB, patch)
2016-01-03 18:11 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
4. Show new graph data. (29.27 KB, patch)
2016-01-03 18:11 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2016-01-03 15:13:11 PST 
Avoid doing a lot of processing during the benchmark itself. Also show raw data on top of the filtered data.
Comment 1 Radar WebKit Bug Importer 2016-01-03 15:13:25 PST 
<rdar://problem/24033996>
Comment 2 Jon Lee 2016-01-03 18:04:23 PST 
Created attachment 268165 [details]
Patch
Comment 3 Jon Lee 2016-01-03 18:10:30 PST 
Created attachment 268166 [details]
1. Avoid processing the data through the Experiment while the test is running.
Comment 4 Jon Lee 2016-01-03 18:10:51 PST 
Created attachment 268167 [details]
2. Refactor how Animator does its recording.
Comment 5 Jon Lee 2016-01-03 18:11:14 PST 
Created attachment 268168 [details]
3. Producing the JSON can take a while with all of the data.
Comment 6 Jon Lee 2016-01-03 18:11:34 PST 
Created attachment 268169 [details]
4. Show new graph data.
Comment 7 Simon Fraser (smfr) 2016-01-03 18:22:01 PST 
Comment on attachment 268165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268165&action=review

> PerformanceTests/Animometer/resources/debug-runner/animometer.js:362
> +        document.querySelector("#results-json button").remove();

Does .remove() work in all browsers we care about?
Comment 8 Jon Lee 2016-01-03 18:24:43 PST 
(In reply to comment #7)
> Comment on attachment 268165 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268165&action=review
> 
> > PerformanceTests/Animometer/resources/debug-runner/animometer.js:362
> > +        document.querySelector("#results-json button").remove();
> 
> Does .remove() work in all browsers we care about?

Yes.
Comment 9 Jon Lee 2016-01-03 18:37:35 PST 
Committed r194523: <http://trac.webkit.org/changeset/194523>