Bug 152663 – AX: incorrect accessible name from multiple label elements

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Zoë Bijl]

Created attachment 268138 [details]
Error message mechanism with multiple labels

When multiple <label> elements are associated with a label-able element, the accessible name should be the product of the text content of each of the labels concatenated by DOM source order and space separated.

Expected result:
All associated label elements are used, in DOM order, for name calculation.

Actual result:
Only the first associated label element that is encountered in the DOM is used for name calculation.

Code example courtesy of Steve Faulkner.

[Radar WebKit Bug Importer]

<rdar://problem/24033482>

[Thibaud Colas]

The report is pretty clear as it is but I’ve had to discover and research this bug myself so adding the details here.

Relevant specification on accessible name computation: https://www.w3.org/TR/html-aam-1.0/#input-type-text-input-type-password-input-type-search-input-type-tel-input-type-url-and-textarea-element

Extract (matching what Zoë has reported):

> Otherwise use the associated label element(s) accessible name(s) - if more than one label is associated; concatenate by DOM order, delimited by spaces.

Real-world example of this bug if it helps: https://github.com/django/django/pull/14389, https://code.djangoproject.com/ticket/32338

[Tyler Wilcock]

*** Bug 254812 has been marked as a duplicate of this bug. ***

[Tyler Wilcock]

Created attachment 467052 [details]
Patch

[Tyler Wilcock]

Created attachment 467053 [details]
Patch

[chris fleizach]

Comment on attachment 467053 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467053&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:248
> +    return labels.isEmpty() ? nullptr : labels.first();

does labels.first() return nil if it's empty anyway? or does it crash

[Tyler Wilcock]

(In reply to chris fleizach from comment #6)
> Comment on attachment 467053 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467053&action=review
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:248
> > +    return labels.isEmpty() ? nullptr : labels.first();
> 
> does labels.first() return nil if it's empty anyway? or does it crash
It would crash, as Vector::first() does an unchecked access into the vector.

[EWS]

Committed 266151@main (3c4dcc0a6eb0): <https://commits.webkit.org/266151@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467053 [details].

[Zoë Bijl]

Woohoo, thank you!