Bug 152660 - Overflow scrollIntoView wrong with borders
Summary: Overflow scrollIntoView wrong with borders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-02 21:43 PST by Simon Fraser (smfr)
Modified: 2020-10-27 14:05 PDT (History)
10 users (show)

See Also:

Attachments
Testcase (1.21 KB, text/html)
2016-01-02 21:43 PST, Simon Fraser (smfr) 		no flags Details
Patch (10.24 KB, patch)
2020-10-26 08:17 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (17.48 KB, patch)
2020-10-27 11:14 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-01-02 21:43:33 PST 
Created attachment 268128 [details]
Testcase

Attached test case should scroll to 0 (or -200 in Firefox), not 10. The border is messing things up.
Comment 1 Simon Fraser (smfr) 2016-01-03 08:53:57 PST 
I think this line maps into local coordinates, but those include the border box:

        LayoutRect localExposeRect(box->absoluteToLocalQuad(FloatQuad(FloatRect(rect))).boundingBox());
Comment 2 Martin Robinson 2020-10-26 08:17:22 PDT 
Created attachment 412317 [details]
Patch
Comment 3 Martin Robinson 2020-10-26 13:43:19 PDT 
Looks like there are a few one pixel differences and some new passes. I should be able to update the results for these tomorrow.
Comment 4 Martin Robinson 2020-10-27 11:14:20 PDT 
Created attachment 412448 [details]
Patch
Comment 5 EWS 2020-10-27 14:04:20 PDT 
Committed r269070: <https://trac.webkit.org/changeset/269070>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412448 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-27 14:05:19 PDT 
<rdar://problem/70737529>