RESOLVED FIXED152659
Web Inspector: Visual sidebar selector section displays inherited section for non-editable rules 
https://bugs.webkit.org/show_bug.cgi?id=152659
Summary Web Inspector: Visual sidebar selector section displays inherited section for...
Devin Rousso
Reported 2016-01-02 21:40:48 PST
Created attachment 268126 [details] Screenshot of Bug See attached screenshot (look at the two sections that are back to back called "Inherited from center" and "Inherited from body#gsr.hp.vasq")
Attachments
Screenshot of Bug (45.17 KB, image/png)
2016-01-02 21:40 PST, Devin Rousso 		no flags
Details
Patch (2.59 KB, patch)
2016-01-02 21:42 PST, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
Patch (2.47 KB, patch)
2016-01-03 18:00 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-02 21:40:58 PST
<rdar://problem/24032590>
Devin Rousso
Comment 2 2016-01-02 21:42:44 PST
Created attachment 268127 [details] Patch
Blaze Burg
Comment 3 2016-01-03 15:44:44 PST
Comment on attachment 268127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268127&action=review r=me > Source/WebInspectorUI/ChangeLog:10 > + Only add a new inherited section header once the first inherited rule is added. Please edit this comment to say "if it will contain at least one inherited rule". The separator is added before the inherited rule, not after it.
Devin Rousso
Comment 4 2016-01-03 18:00:55 PST
Created attachment 268163 [details] Patch Good call on the comment @Brian.
WebKit Commit Bot
Comment 5 2016-01-03 18:58:33 PST
Comment on attachment 268163 [details] Patch Clearing flags on attachment: 268163 Committed r194524: <http://trac.webkit.org/changeset/194524>
WebKit Commit Bot
Comment 6 2016-01-03 18:58:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.