Bug 152659 - Web Inspector: Visual sidebar selector section displays inherited section for non-editable rules
Summary: Web Inspector: Visual sidebar selector section displays inherited section for...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-02 21:40 PST by Devin Rousso
Modified: 2016-01-03 20:49 PST (History)
8 users (show)

See Also:

Attachments
Screenshot of Bug (45.17 KB, image/png)
2016-01-02 21:40 PST, Devin Rousso 		no flags Details
Patch (2.59 KB, patch)
2016-01-02 21:42 PST, Devin Rousso 		bburg: review+
Details | Formatted Diff | Diff
Patch (2.47 KB, patch)
2016-01-03 18:00 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-01-02 21:40:48 PST 
Created attachment 268126 [details]
Screenshot of Bug

See attached screenshot (look at the two sections that are back to back called "Inherited from center" and "Inherited from body#gsr.hp.vasq")
Comment 1 Radar WebKit Bug Importer 2016-01-02 21:40:58 PST 
<rdar://problem/24032590>
Comment 2 Devin Rousso 2016-01-02 21:42:44 PST 
Created attachment 268127 [details]
Patch
Comment 3 BJ Burg 2016-01-03 15:44:44 PST 
Comment on attachment 268127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268127&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +        Only add a new inherited section header once the first inherited rule is added.

Please edit this comment to say "if it will contain at least one inherited rule". The separator is added before the inherited rule, not after it.
Comment 4 Devin Rousso 2016-01-03 18:00:55 PST 
Created attachment 268163 [details]
Patch

Good call on the comment @Brian.
Comment 5 WebKit Commit Bot 2016-01-03 18:58:33 PST 
Comment on attachment 268163 [details]
Patch

Clearing flags on attachment: 268163

Committed r194524: <http://trac.webkit.org/changeset/194524>
Comment 6 WebKit Commit Bot 2016-01-03 18:58:38 PST 
All reviewed patches have been landed.  Closing bug.