Bug 152654 - Build fails for aarch64/linux on when building with clang
Summary: Build fails for aarch64/linux on when building with clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-02 14:58 PST by Khem Raj
Modified: 2016-01-03 12:09 PST (History)
7 users (show)

See Also:


Attachments
Fix aarch64/linux build with clang (2.00 KB, patch)
2016-01-02 15:06 PST, Khem Raj
no flags Details | Formatted Diff | Diff
patch to fix clang/aarch64/Linux (2.09 KB, patch)
2016-01-03 10:45 PST, Khem Raj
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Khem Raj 2016-01-02 14:58:35 PST
On OpenEmbedded when building webkitgtk using clang for aarch64/linux target build fails with

Source/JavaScriptCore/assembler/ARM64Assembler.h:2857:33: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'void *'
        __builtin___clear_cache(reinterpret_cast<void*>(begin), reinterpret_cast<void*>(end));
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Comment 1 Khem Raj 2016-01-02 15:06:02 PST
Created attachment 268114 [details]
Fix aarch64/linux build with clang
Comment 2 Michael Saboff 2016-01-02 15:19:36 PST
Comment on attachment 268114 [details]
Fix aarch64/linux build with clang

r=me
Comment 3 WebKit Commit Bot 2016-01-02 16:04:43 PST
Comment on attachment 268114 [details]
Fix aarch64/linux build with clang

Clearing flags on attachment: 268114

Committed r194505: <http://trac.webkit.org/changeset/194505>
Comment 4 WebKit Commit Bot 2016-01-02 16:04:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Daniel Bates 2016-01-02 21:30:51 PST
(In reply to comment #3)
> Comment on attachment 268114 [details]
> Fix aarch64/linux build with clang
> 
> Clearing flags on attachment: 268114
> 
> Committed r194505: <http://trac.webkit.org/changeset/194505>

The ChangeLog entry for this change neither lists the name of the reviewer (Michael Saboff) nor conforms to format of a ChangeLog entry described in <https://webkit.org/contributing-code/#changelog-files>.

Even though this a build fix (which could be landed by a committer/reviewer "Unreviewed") it was formally reviewed and landed. Therefore its ChangeLog should reflect the reviewer.
Comment 6 Khem Raj 2016-01-03 10:45:58 PST
Created attachment 268142 [details]
patch to fix clang/aarch64/Linux

Addressed review comments.
Comment 7 Filip Pizlo 2016-01-03 12:08:51 PST
Fixed the ChangeLog in http://trac.webkit.org/changeset/194517
Comment 8 Filip Pizlo 2016-01-03 12:09:14 PST
Comment on attachment 268142 [details]
patch to fix clang/aarch64/Linux

Obsolete patch.