Bug 152647 – Web Inspector: List all resources that are initiated by the selected resource in the Network tab

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

While debugging 3rd party scripts, I often find myself wanting to be able to see what each resource loads.  It is currently possible to just look at each loaded resource and compare all the "Initiated" values, but this is very time consuming if there are a lot of loaded resources.  As such, I think that adding another section just below that called "Initiated" which lists all the resources loaded by the selected one would be helpful.

[Radar WebKit Bug Importer]

<rdar://problem/24031233>

[Devin Rousso]

Created attachment 268082 [details]
Patch

[Devin Rousso]

Created attachment 268083 [details]
After patch is applied

[Timothy Hatcher]

Comment on attachment 268082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268082&action=review

Very cool!

> Source/WebInspectorUI/UserInterface/Base/Main.js:2170
> +WebInspector.createResourceLink = function(resource, className)
> +{
> +    function handleClick(event)
> +    {
> +        event.stopPropagation();
> +        event.preventDefault();
> +
> +        WebInspector.showRepresentedObject(resource);
> +    }
> +
> +    let linkNode = document.createElement("a");
> +    linkNode.classList.add("resource-link", className);
> +    linkNode.title = resource.url;
> +    linkNode.textContent = (resource.urlComponents.lastPathComponent || resource.url).insertWordBreakCharacters();
> +    linkNode.addEventListener("click", handleClick.bind(this));
> +    return linkNode;
> +}
> +
> +WebInspector.createResourceLinkContainer = function(resources, containerClass, linkClass) {
> +    let resourceLinkContainer = document.createElement("div");
> +    resourceLinkContainer.classList.add("resource-list", containerClass);
> +    for (let resource of resources)
> +        resourceLinkContainer.appendChild(WebInspector.createResourceLink(resource, linkClass));
> +    return resourceLinkContainer;
> +}

This might be too special case to be reusable. Maybe just put in the sidebar code for now.

> Source/WebInspectorUI/UserInterface/Views/Main.css:255
> +    content: "-";

I don't think we need this. One per line is likely enough.

[Devin Rousso]

Created attachment 268111 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 268111 [details]
Patch

Rejecting attachment 268111 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 268111, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ws/Main.css
Hunk #1 FAILED at 243.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/Main.css.rej
patching file Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js
Hunk #1 FAILED at 219.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/640937

[Devin Rousso]

Created attachment 268116 [details]
Patch

Gotta love localizedStrings.js...

[WebKit Commit Bot]

Comment on attachment 268116 [details]
Patch

Rejecting attachment 268116 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 268116, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebInspectorUI/ChangeLog is not at the top of the file.

Full output: http://webkit-queues.webkit.org/results/641240

[Devin Rousso]

Created attachment 268117 [details]
Patch

Damn I'm just getting sloppy...

[WebKit Commit Bot]

Comment on attachment 268117 [details]
Patch

Clearing flags on attachment: 268117

Committed r194506: <http://trac.webkit.org/changeset/194506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Devin Rousso]

Reopening to attach new patch.

[Devin Rousso]

Created attachment 268122 [details]
Patch

[Devin Rousso]

Comment on attachment 268122 [details]
Patch

Sorry I copied the wrong bug number.