RESOLVED FIXED152631
Web Inspector: Add list-style properties to Visual Sidebar 
https://bugs.webkit.org/show_bug.cgi?id=152631
Summary Web Inspector: Add list-style properties to Visual Sidebar
Devin Rousso
Reported 2015-12-31 16:39:55 PST
Add list-style-type, list-style-position, and list-style-image as another section under Background.
Attachments
Patch (15.09 KB, patch)
2015-12-31 18:05 PST, Devin Rousso 		timothy: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (14.54 KB, patch)
2016-01-02 13:37 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-12-31 16:40:07 PST
<rdar://problem/24029772>
Devin Rousso
Comment 2 2015-12-31 18:05:44 PST
Created attachment 268061 [details] Patch
WebKit Commit Bot
Comment 3 2016-01-02 12:46:17 PST
Comment on attachment 268061 [details] Patch Rejecting attachment 268061 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 268061, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: imothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Parsed 9 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Original content of Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js mismatches at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 283. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/640709
Devin Rousso
Comment 4 2016-01-02 13:37:28 PST
Created attachment 268110 [details] Patch
WebKit Commit Bot
Comment 5 2016-01-02 14:33:16 PST
Comment on attachment 268110 [details] Patch Clearing flags on attachment: 268110 Committed r194504: <http://trac.webkit.org/changeset/194504>
WebKit Commit Bot
Comment 6 2016-01-02 14:33:20 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 7 2016-01-04 15:57:33 PST
Comment on attachment 268110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268110&action=review > Source/WebInspectorUI/UserInterface/Images/ListStylePositionInside.svg:1 > +<?xml version="1.0" encoding="utf-8"?> Cool! > Source/WebInspectorUI/UserInterface/Main.html:602 > <script src="Views/VisualStyleUnitSlider.js"></script> > + <script src="Views/VisualStyleURLInput.js"></script> Actually, according to `/usr/bin/sort` these "URL" < "Unit"
Devin Rousso
Comment 8 2016-01-04 15:59:20 PST
Comment on attachment 268110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268110&action=review >> Source/WebInspectorUI/UserInterface/Main.html:602 >> + <script src="Views/VisualStyleURLInput.js"></script> > > Actually, according to `/usr/bin/sort` these "URL" < "Unit" Oh...well I can fix that in the next Visual sidebar patch.
Note You need to log in before you can comment on or make changes to this bug.