Bug 152617 - More scrollOffset/scrollPosition disambiguation, in RenderLayer
Summary: More scrollOffset/scrollPosition disambiguation, in RenderLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-31 10:07 PST by Simon Fraser (smfr)
Modified: 2015-12-31 12:08 PST (History)
6 users (show)

See Also:

Attachments
Patch (28.70 KB, patch)
2015-12-31 10:11 PST, Simon Fraser (smfr) 		zalan: review+
Details | Formatted Diff | Diff
Patch (32.51 KB, patch)
2015-12-31 10:27 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-12-31 10:07:38 PST 
More scrollOffset/scrollPosition disambiguation, in RenderLayer
Comment 1 Simon Fraser (smfr) 2015-12-31 10:11:20 PST 
Created attachment 268044 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-31 10:13:52 PST 
Attachment 268044 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlock.cpp:2877:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:2878:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 zalan 2015-12-31 10:17:57 PST 
Comment on attachment 268044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268044&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3580
> +    // FIXME: is point a ScrollOffset or ScrollPosition? Test in RTL overflow.

:(
Comment 4 Simon Fraser (smfr) 2015-12-31 10:27:43 PST 
Created attachment 268046 [details]
Patch
Comment 5 WebKit Commit Bot 2015-12-31 10:51:11 PST 
Attachment 268046 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlock.cpp:2877:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/rendering/RenderBlock.cpp:2878:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Simon Fraser (smfr) 2015-12-31 12:08:29 PST 
https://trac.webkit.org/changeset/194466