Bug 152611 - [CMake] Add error checking to catch option manipulation after WEBKIT_OPTION_END
Summary: [CMake] Add error checking to catch option manipulation after WEBKIT_OPTION_END
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-31 07:43 PST by Michael Catanzaro
Modified: 2015-12-31 09:12 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.26 KB, patch)
2015-12-31 07:52 PST, Michael Catanzaro
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-12-31 07:43:33 PST
If WEBKIT_OPTION_DEFINE is called after WEBKIT_OPTION_END, the option never makes its way into FEATURE_DEFINES and so will be inconsistently set (available to most of the build, but not to the DOM bindings generator, for example).

If WEBKIT_OPTION_DEFAULT_PORT_VALUE, WEBKIT_OPTION_CONFLICT, or WEBKIT_OPTION_DEPEND are called after WEBKIT_OPTION_END, they don't do anything.

Add error checking to catch these bugs.
Comment 1 Michael Catanzaro 2015-12-31 07:52:05 PST
Created attachment 268034 [details]
Patch
Comment 2 Michael Catanzaro 2015-12-31 09:12:27 PST
Committed r194454: <http://trac.webkit.org/changeset/194454>