Bug 152606 - Clarify that scrollPositionChangedViaPlatformWidget takes offsets
Summary: Clarify that scrollPositionChangedViaPlatformWidget takes offsets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-30 21:54 PST by Simon Fraser (smfr)
Modified: 2015-12-31 11:36 PST (History)
8 users (show)

See Also:


Attachments
Patch (15.79 KB, patch)
2015-12-30 21:56 PST, Simon Fraser (smfr)
zalan: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-12-30 21:54:28 PST
Clarify that scrollPositionChangedViaPlatformWidget takes offsets
Comment 1 Simon Fraser (smfr) 2015-12-30 21:56:55 PST
Created attachment 268028 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-31 11:03:56 PST
Comment on attachment 268028 [details]
Patch

Rejecting attachment 268028 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 268028, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
1 lines).
Hunk #2 FAILED at 487.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/ScrollView.cpp.rej
patching file Source/WebCore/platform/ScrollView.h
patching file Source/WebCore/platform/ScrollableArea.cpp
patching file Source/WebCore/platform/ScrollableArea.h
patching file Source/WebKit/mac/WebView/WebHTMLView.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/631570
Comment 3 Simon Fraser (smfr) 2015-12-31 11:36:08 PST
https://trac.webkit.org/changeset/194463