Bug 152600 – Modern IDB: storage/indexeddb/database-deletepending-flag.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB: storage/indexeddb/database-deletepending-flag.html fails

We didn't *actually* delete the backing store when handling a delete operation in the server.

Therefore a new fresh backing store was never created, which this test expects.

[Brady Eidson]

Created attachment 268012 [details]
Patch v1

[Brady Eidson]

Doesn't apply to trunk because it builds off of the patch in 152593  =/

[Andy Estes]

I just reviewed 152593, if you want to land that and resubmit this for EWS analysis.

[Alex Christensen]

Comment on attachment 268012 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=268012&action=review

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:187
> +    BackingStoreDeleteMode deleteMode = m_pendingOpenDBRequests.isEmpty() ? BackingStoreDeleteMode::DeleteOnly : BackingStoreDeleteMode::DeleteThenReopen;

Is it possible to make an open db request between starting and finishing deleting a backing store?

[Brady Eidson]

Created attachment 268026 [details]
Patch v1

[Brady Eidson]

(In reply to comment #4)
> Comment on attachment 268012 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268012&action=review
> 
> > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:187
> > +    BackingStoreDeleteMode deleteMode = m_pendingOpenDBRequests.isEmpty() ? BackingStoreDeleteMode::DeleteOnly : BackingStoreDeleteMode::DeleteThenReopen;
> 
> Is it possible to make an open db request between starting and finishing
> deleting a backing store?

Great question - Yes.

I'll rethink the async call. Won't be too hard to fix that issue...  but it will be nigh impossible to test.  =/

[Brady Eidson]

Created attachment 268070 [details]
Patch v2

Without the bug Alex spotted, and much simpler anyways.

[WebKit Commit Bot]

Comment on attachment 268070 [details]
Patch v2

Clearing flags on attachment: 268070

Committed r194488: <http://trac.webkit.org/changeset/194488>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.