RESOLVED FIXED152596
Simplify the CachedScript ASCII optimization. 
https://bugs.webkit.org/show_bug.cgi?id=152596
Summary Simplify the CachedScript ASCII optimization.
Andreas Kling
Reported 2015-12-30 08:17:49 PST
The non-copying StringImpl juggling in CachedScript is scary and lame.
Attachments
Patch (7.73 KB, patch)
2015-12-30 08:18 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-12-30 08:18:26 PST
Created attachment 268004 [details] Patch
Antti Koivisto
Comment 2 2016-01-02 10:02:04 PST
Comment on attachment 268004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268004&action=review > Source/WebCore/platform/text/TextEncoding.h:75 > + bool isByteBasedEncoding() const { return !isNonByteBasedEncoding(); } Could we just reverse and rename isNonByteBasedEncoding?
Andreas Kling
Comment 3 2016-01-04 02:44:30 PST
Comment on attachment 268004 [details] Patch We could, but I didn't want this patch to get all TextEncoding-heavy. :| Can do separately.
WebKit Commit Bot
Comment 4 2016-01-04 03:30:35 PST
Comment on attachment 268004 [details] Patch Clearing flags on attachment: 268004 Committed r194529: <http://trac.webkit.org/changeset/194529>
WebKit Commit Bot
Comment 5 2016-01-04 03:30:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.