Bug 152596 - Simplify the CachedScript ASCII optimization.
Summary: Simplify the CachedScript ASCII optimization.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-30 08:17 PST by Andreas Kling
Modified: 2016-01-04 03:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.73 KB, patch)
2015-12-30 08:18 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-12-30 08:17:49 PST 
The non-copying StringImpl juggling in CachedScript is scary and lame.
Comment 1 Andreas Kling 2015-12-30 08:18:26 PST 
Created attachment 268004 [details]
Patch
Comment 2 Antti Koivisto 2016-01-02 10:02:04 PST 
Comment on attachment 268004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268004&action=review

> Source/WebCore/platform/text/TextEncoding.h:75
> +        bool isByteBasedEncoding() const { return !isNonByteBasedEncoding(); }

Could we just reverse and rename isNonByteBasedEncoding?
Comment 3 Andreas Kling 2016-01-04 02:44:30 PST 
Comment on attachment 268004 [details]
Patch

We could, but I didn't want this patch to get all TextEncoding-heavy. :|
Can do separately.
Comment 4 WebKit Commit Bot 2016-01-04 03:30:35 PST 
Comment on attachment 268004 [details]
Patch

Clearing flags on attachment: 268004

Committed r194529: <http://trac.webkit.org/changeset/194529>
Comment 5 WebKit Commit Bot 2016-01-04 03:30:39 PST 
All reviewed patches have been landed.  Closing bug.