Bug 152571 - [EFL] Inspector is broken
Summary: [EFL] Inspector is broken
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-27 18:28 PST by Hunseop Jeong
Modified: 2017-03-11 10:52 PST (History)
5 users (show)

See Also:


Attachments
Inspector screenshot (201.06 KB, image/png)
2015-12-27 20:33 PST, Gyuyoung Kim
no flags Details
inspector capture jpg (85.93 KB, image/jpeg)
2015-12-27 20:51 PST, Joonghun Park
no flags Details
Patch (8.95 KB, patch)
2015-12-28 21:17 PST, Hunseop Jeong
gyuyoung.kim: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-12-27 18:28:02 PST
I failed to run the inspector on MiniBrowser with below message.
"ERR<6607>:EvasGL modules/evas/engines/gl_common/evas_gl_core.c:1335 _internal_config_set() Win cfg can't support Evas GL DR, win: [depth 0, stencil 0, msaa 0] want: [depth 8, stencil 0, msaa 0]"

Is it my ubuntu's problem? Is everyone all right?
Comment 1 Gyuyoung Kim 2015-12-27 20:33:54 PST
Created attachment 267949 [details]
Inspector screenshot

In my local box, inpector is shown though, screen is broken :(
Comment 2 Joonghun Park 2015-12-27 20:51:47 PST
Created attachment 267950 [details]
inspector capture jpg

My Ubuntu is 15.10 and using nvidia graphic driver.
In my env, it seems that inspector is shown well.
Comment 3 Hunseop Jeong 2015-12-28 04:11:14 PST
Thanks for checking the inspector.
My inspector screen is same with gyuyoungs' inspector.
I will investigate this issue.
Comment 4 Hunseop Jeong 2015-12-28 21:17:19 PST
Created attachment 267980 [details]
Patch
Comment 5 Gyuyoung Kim 2015-12-28 21:25:33 PST
Comment on attachment 267980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267980&action=review

> Source/WebKit2/PlatformEfl.cmake:295
> +    ${ELEMENTARY_INCLUDE_DIRS}

This causes circular dependency with elementary libarary. elm_web is included in the elementary.
Comment 6 Hunseop Jeong 2015-12-28 21:26:38 PST
This issue looks efl issue.
I think best approach is setting the depth of the ecore_evas's win to 8.
But I don't know how to set the depth of ecore_evas window.
If anyone know to set the depth, plz tell me.

This patch changed the inspector window to use the elm_win instead of the ecore_evas like as the MiniBrowser.
Comment 7 Hunseop Jeong 2015-12-28 21:28:24 PST
(In reply to comment #5)
> Comment on attachment 267980 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267980&action=review
> 
> > Source/WebKit2/PlatformEfl.cmake:295
> > +    ${ELEMENTARY_INCLUDE_DIRS}
> 
> This causes circular dependency with elementary libarary. elm_web is
> included in the elementary.

Um,, So,, We don't use the elementary?
Comment 8 Gyuyoung Kim 2015-12-28 21:35:13 PST
(In reply to comment #7)
> (In reply to comment #5)
> > Comment on attachment 267980 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=267980&action=review
> > 
> > > Source/WebKit2/PlatformEfl.cmake:295
> > > +    ${ELEMENTARY_INCLUDE_DIRS}
> > 
> > This causes circular dependency with elementary libarary. elm_web is
> > included in the elementary.
> 
> Um,, So,, We don't use the elementary?

yes, current dependency is as below,

WebKit EFL -> elm_web -> elementary

If you use elementary in WebKit EFL, you make circular dependency as below,

WebKit EFL -> elm_web -> elementary -> WebKit EFL.

That's why we have used it only for MiniBrowser.
Comment 9 Hunseop Jeong 2015-12-28 21:42:10 PST
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #5)
> > > Comment on attachment 267980 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=267980&action=review
> > > 
> > > > Source/WebKit2/PlatformEfl.cmake:295
> > > > +    ${ELEMENTARY_INCLUDE_DIRS}
> > > 
> > > This causes circular dependency with elementary libarary. elm_web is
> > > included in the elementary.
> > 
> > Um,, So,, We don't use the elementary?
> 
> yes, current dependency is as below,
> 
> WebKit EFL -> elm_web -> elementary
> 
> If you use elementary in WebKit EFL, you make circular dependency as below,
> 
> WebKit EFL -> elm_web -> elementary -> WebKit EFL.
> 
> That's why we have used it only for MiniBrowser.

I understand, We have to find the way to set the depth for the ecore_evas.
I will ask efl's folks. Thanks.
Comment 10 Hunseop Jeong 2015-12-28 22:23:38 PST
Install the libosmesa6-dev package and set the engine name with depth and stencil information, then inspector screen looks correct. But segmentation fault occurred. :(

Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp

const char* engine = "opengl:depth24:stencil8";
m_inspectorWindow = ecore_evas_new(engine, 0, 0, initialWindowWidth, initialWindowHeight, nullptr);
Comment 11 Michael Catanzaro 2017-03-11 10:52:44 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.