RESOLVED WONTFIX 152571
[EFL] Inspector is broken
https://bugs.webkit.org/show_bug.cgi?id=152571
Summary [EFL] Inspector is broken
Hunseop Jeong
Reported 2015-12-27 18:28:02 PST
I failed to run the inspector on MiniBrowser with below message. "ERR<6607>:EvasGL modules/evas/engines/gl_common/evas_gl_core.c:1335 _internal_config_set() Win cfg can't support Evas GL DR, win: [depth 0, stencil 0, msaa 0] want: [depth 8, stencil 0, msaa 0]" Is it my ubuntu's problem? Is everyone all right?
Attachments
Inspector screenshot (201.06 KB, image/png)
2015-12-27 20:33 PST, Gyuyoung Kim
no flags
inspector capture jpg (85.93 KB, image/jpeg)
2015-12-27 20:51 PST, Joonghun Park
no flags
Patch (8.95 KB, patch)
2015-12-28 21:17 PST, Hunseop Jeong
gyuyoung.kim: review-
Gyuyoung Kim
Comment 1 2015-12-27 20:33:54 PST
Created attachment 267949 [details] Inspector screenshot In my local box, inpector is shown though, screen is broken :(
Joonghun Park
Comment 2 2015-12-27 20:51:47 PST
Created attachment 267950 [details] inspector capture jpg My Ubuntu is 15.10 and using nvidia graphic driver. In my env, it seems that inspector is shown well.
Hunseop Jeong
Comment 3 2015-12-28 04:11:14 PST
Thanks for checking the inspector. My inspector screen is same with gyuyoungs' inspector. I will investigate this issue.
Hunseop Jeong
Comment 4 2015-12-28 21:17:19 PST
Gyuyoung Kim
Comment 5 2015-12-28 21:25:33 PST
Comment on attachment 267980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267980&action=review > Source/WebKit2/PlatformEfl.cmake:295 > + ${ELEMENTARY_INCLUDE_DIRS} This causes circular dependency with elementary libarary. elm_web is included in the elementary.
Hunseop Jeong
Comment 6 2015-12-28 21:26:38 PST
This issue looks efl issue. I think best approach is setting the depth of the ecore_evas's win to 8. But I don't know how to set the depth of ecore_evas window. If anyone know to set the depth, plz tell me. This patch changed the inspector window to use the elm_win instead of the ecore_evas like as the MiniBrowser.
Hunseop Jeong
Comment 7 2015-12-28 21:28:24 PST
(In reply to comment #5) > Comment on attachment 267980 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267980&action=review > > > Source/WebKit2/PlatformEfl.cmake:295 > > + ${ELEMENTARY_INCLUDE_DIRS} > > This causes circular dependency with elementary libarary. elm_web is > included in the elementary. Um,, So,, We don't use the elementary?
Gyuyoung Kim
Comment 8 2015-12-28 21:35:13 PST
(In reply to comment #7) > (In reply to comment #5) > > Comment on attachment 267980 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=267980&action=review > > > > > Source/WebKit2/PlatformEfl.cmake:295 > > > + ${ELEMENTARY_INCLUDE_DIRS} > > > > This causes circular dependency with elementary libarary. elm_web is > > included in the elementary. > > Um,, So,, We don't use the elementary? yes, current dependency is as below, WebKit EFL -> elm_web -> elementary If you use elementary in WebKit EFL, you make circular dependency as below, WebKit EFL -> elm_web -> elementary -> WebKit EFL. That's why we have used it only for MiniBrowser.
Hunseop Jeong
Comment 9 2015-12-28 21:42:10 PST
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #5) > > > Comment on attachment 267980 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=267980&action=review > > > > > > > Source/WebKit2/PlatformEfl.cmake:295 > > > > + ${ELEMENTARY_INCLUDE_DIRS} > > > > > > This causes circular dependency with elementary libarary. elm_web is > > > included in the elementary. > > > > Um,, So,, We don't use the elementary? > > yes, current dependency is as below, > > WebKit EFL -> elm_web -> elementary > > If you use elementary in WebKit EFL, you make circular dependency as below, > > WebKit EFL -> elm_web -> elementary -> WebKit EFL. > > That's why we have used it only for MiniBrowser. I understand, We have to find the way to set the depth for the ecore_evas. I will ask efl's folks. Thanks.
Hunseop Jeong
Comment 10 2015-12-28 22:23:38 PST
Install the libosmesa6-dev package and set the engine name with depth and stencil information, then inspector screen looks correct. But segmentation fault occurred. :( Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp const char* engine = "opengl:depth24:stencil8"; m_inspectorWindow = ecore_evas_new(engine, 0, 0, initialWindowWidth, initialWindowHeight, nullptr);
Michael Catanzaro
Comment 11 2017-03-11 10:52:44 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note You need to log in before you can comment on or make changes to this bug.