Bug 152559 - ASSERT(m_nsResponse) in ResourceResponse::platformCertificateInfo() when running tests in iOS simulator
Summary: ASSERT(m_nsResponse) in ResourceResponse::platformCertificateInfo() when runn...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2015-12-25 10:51 PST by Alexey Proskuryakov
Modified: 2015-12-25 12:47 PST (History)
7 users (show)

See Also:

proposed fix (1.56 KB, patch)
2015-12-25 11:05 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-12-25 10:51:44 PST
I get this assertion every time when running tests in debug mode. It's a regression, as I've been able to run tests in debug mode a few months ago.

$ run-webkit-tests --ios-simulator js/intl-collator.html --no-retry --no-timeout

#1	0x0000000110eb3455 in WebCore::ResourceResponse::platformCertificateInfo() const at /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:70
#2	0x0000000112461cb4 in WebCore::ResourceResponseBase::includeCertificateInfo() const at /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/network/ResourceResponseBase.cpp:181
#3	0x00000001098c6962 in WebKit::NetworkLoad::sharedDidReceiveResponse(WebCore::ResourceResponse const&) at /Volumes/Data/Safari/OpenSource/Source/WebKit2/NetworkProcess/NetworkLoad.cpp:141
#4	0x00000001098c6b6d in WebKit::NetworkLoad::didReceiveResponseAsync(WebCore::ResourceHandle*, WebCore::ResourceResponse const&) at /Volumes/Data/Safari/OpenSource/Source/WebKit2/NetworkProcess/NetworkLoad.cpp:232
#5	0x00000001124510e5 in ::___ZN7WebCore55ResourceHandleCFURLConnectionDelegateWithOperationQueue18didReceiveResponseEP16_CFURLConnectionP14_CFURLResponse_block_invoke() at /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:162
Comment 1 Alexey Proskuryakov 2015-12-25 10:54:25 PST
When this happens, m_nsResponse is null, but m_cfResponse is not null.

I'm beginning to suspect http://trac.webkit.org/r194378
Comment 2 Alexey Proskuryakov 2015-12-25 11:05:40 PST
Created attachment 267921 [details]
proposed fix

Yes, definitely that.

I just made sure that this test runs, and didn't audit the rest of the patch. It's probably worth another look.
Comment 3 WebKit Commit Bot 2015-12-25 12:47:10 PST
Comment on attachment 267921 [details]
proposed fix

Clearing flags on attachment: 267921

Committed r194420: <http://trac.webkit.org/changeset/194420>
Comment 4 WebKit Commit Bot 2015-12-25 12:47:14 PST
All reviewed patches have been landed.  Closing bug.