This allows us to use old options names as well. This is for the benefit of third party tools which may have been built to rely on those old options.
Created attachment 267906 [details] proposed patch.
Attachment 267906 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Options.cpp:584: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/Options.cpp:589: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Which tools rely on old options? Who are the third parties?
(In reply to comment #3) > Which tools rely on old options? Who are the third parties? We often tell people to use our options. They are all internal clients.
Thanks for the review. Landed in r194591: <http://trac.webkit.org/r194591>.
Re-opened since this is blocked by bug 152750
The requested was invalid.
(In reply to comment #7) > The requested was invalid. I meant "requested rollout".
Comment on attachment 267906 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=267906&action=review > Source/JavaScriptCore/jsc.cpp:1973 > - JSC::Options::dumpAllOptions(stderr, JSC::Options::DumpLevel::Verbose, "All JSC runtime options:"); > + JSC::Options::dumpAllOptions(stderr, JSC::Options::DumpLevel::Overridden, "All JSC runtime options:"); Now there is no way to dump all options without modifying the source code. :-/ And in this case the help message of --options and --dumpOptions are misleading.