Bug 152541 - REGRESSION (r187593): Scroll position jumps when selecting text in an iframe
Summary: REGRESSION (r187593): Scroll position jumps when selecting text in an iframe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-23 16:09 PST by Simon Fraser (smfr)
Modified: 2015-12-23 20:55 PST (History)
1 user (show)

See Also:

Attachments
Patch (26.09 KB, patch)
2015-12-23 16:21 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-12-23 16:09:36 PST 
REGRESSION (r190487): Scroll position jumps when selecting text in an iframe
Comment 1 Simon Fraser (smfr) 2015-12-23 16:21:00 PST 
Created attachment 267877 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-12-23 16:21:45 PST 
rdar://problem/23886181
Comment 3 Tim Horton 2015-12-23 16:32:04 PST 
Comment on attachment 267877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267877&action=review

> Source/WebCore/platform/graphics/IntPoint.cpp:40
> +IntPoint IntPoint::constrainedBetween(const IntPoint& min, const IntPoint& max) const

A bunch of things do .expandedTo().shrunkTo() to achieve this. Please consider adopting constrainedBetween in some of those places, it makes a looooot more sense.

> Source/WebCore/rendering/RenderLayer.cpp:2456
> +    // This will prevent us from revealing text hidden by the slider in Safari RSS.

Wat
Comment 4 Simon Fraser (smfr) 2015-12-23 20:55:22 PST 
https://trac.webkit.org/changeset/194405