WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
152536
Python SCM should be able to retrieve untracked files - Generic changes
https://bugs.webkit.org/show_bug.cgi?id=152536
Summary
Python SCM should be able to retrieve untracked files - Generic changes
youenn fablet
Reported
2015-12-23 13:02:03 PST
Let's reintroduce patch from
bug 143135
progressively.
Attachments
Patch
(3.33 KB, patch)
2015-12-23 13:08 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(3.34 KB, patch)
2015-12-24 01:48 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2015-12-23 13:08:22 PST
Created
attachment 267853
[details]
Patch
youenn fablet
Comment 2
2015-12-23 13:10:37 PST
Patch reintroduces part of
bug 143135
patch which broke win build.
Brent Fulgham
Comment 3
2015-12-23 13:59:49 PST
Comment on
attachment 267853
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=267853&action=review
This looks fine to me, and seems okay on the EWS. I'd prefer if you used the "os.path.join" methods so we can rely on it working on non-Cygwin Windows as well. r+ assuming you make that change.
> Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:317 > + write_into_file_at_path("test_dir_new/test_file_new", "new stuff")
Could you use the python path stuff so this will work on Windows? E.g., os.path.join("test_dir_new", "test_file_new")?
youenn fablet
Comment 4
2015-12-24 01:48:00 PST
Created
attachment 267894
[details]
Patch for landing
youenn fablet
Comment 5
2015-12-24 01:48:57 PST
Thanks for the review.
> Could you use the python path stuff so this will work on Windows? E.g., > os.path.join("test_dir_new", "test_file_new")?
Sounds good, done in the landing patch.
WebKit Commit Bot
Comment 6
2015-12-24 02:43:17 PST
Comment on
attachment 267894
[details]
Patch for landing Clearing flags on attachment: 267894 Committed
r194415
: <
http://trac.webkit.org/changeset/194415
>
WebKit Commit Bot
Comment 7
2015-12-24 02:43:21 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug