Bug 152532 - [GTK] WebFrameProxy::certificateInfo() may return nullptr
Summary: [GTK] WebFrameProxy::certificateInfo() may return nullptr
Status: RESOLVED DUPLICATE of bug 142375
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-23 11:15 PST by Yusuke Suzuki
Modified: 2015-12-23 12:51 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2015-12-23 11:25 PST, Yusuke Suzuki 		benjamin: review+
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-12-23 11:15:55 PST 
[GTK] WebFrameProxy::certificateInfo() may return nullptr
Comment 1 Yusuke Suzuki 2015-12-23 11:25:22 PST 
Created attachment 267847 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-23 11:26:51 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2015-12-23 12:48:49 PST 
Comment on attachment 267847 [details]
Patch

Thanks for your contribution.

It's a developer error to call this function when certificateInfo() is null. You're right that we should return FALSE instead of crash, but it would be better to do so with g_return_val_if_fail so that we get a runtime critical.

This is already fixed appropriately in bug #142375, so I am going to dup this there. But that bug is blocked on bug #150927. It would be great if another Apple reviewer could look at the patch in bug #150927, since this is a very serious issue for us.
Comment 4 Michael Catanzaro 2015-12-23 12:49:10 PST 

*** This bug has been marked as a duplicate of bug 142375 ***
Comment 5 Michael Catanzaro 2015-12-23 12:51:27 PST 
P.S. In the future, please use the WebKit Gtk component for bugs like this, otherwise only some of us get CCed, and not until you upload your patch.