Bug 152515 - Minor cleanup in RenderBox::canBeProgramaticallyScrolled()
Summary: Minor cleanup in RenderBox::canBeProgramaticallyScrolled()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-22 14:55 PST by Simon Fraser (smfr)
Modified: 2016-01-04 11:03 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.92 KB, patch)
2015-12-22 14:57 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-12-22 14:55:36 PST 
Minor cleanup in RenderBox::canBeProgramaticallyScrolled()
Comment 1 Simon Fraser (smfr) 2015-12-22 14:57:33 PST 
Created attachment 267807 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-12-23 20:55:32 PST 
https://trac.webkit.org/changeset/194404
Comment 3 Said Abou-Hallawa 2016-01-04 11:03:31 PST 
Comment on attachment 267807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267807&action=review

> Source/WebCore/rendering/RenderBox.h:476
> +

Just for consistency and since we have scrollsOverflow(), should not we have the functions:
     bool hasOverflow() const { return hasHorizontalOverflow() || hasVerticalOverflow(); }
     bool hasScrollableOverflow() const { return hasScrollableOverflowX() || hasScrollableOverflowY(); }