RESOLVED FIXED 152515
Minor cleanup in RenderBox::canBeProgramaticallyScrolled() 
https://bugs.webkit.org/show_bug.cgi?id=152515
Summary Minor cleanup in RenderBox::canBeProgramaticallyScrolled()
Simon Fraser (smfr)
Reported 2015-12-22 14:55:36 PST
Minor cleanup in RenderBox::canBeProgramaticallyScrolled()
Attachments
Patch (6.92 KB, patch)
2015-12-22 14:57 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-12-22 14:57:33 PST
Created attachment 267807 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-12-23 20:55:32 PST
https://trac.webkit.org/changeset/194404
Said Abou-Hallawa
Comment 3 2016-01-04 11:03:31 PST
Comment on attachment 267807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267807&action=review > Source/WebCore/rendering/RenderBox.h:476 > + Just for consistency and since we have scrollsOverflow(), should not we have the functions: bool hasOverflow() const { return hasHorizontalOverflow() || hasVerticalOverflow(); } bool hasScrollableOverflow() const { return hasScrollableOverflowX() || hasScrollableOverflowY(); }
Note You need to log in before you can comment on or make changes to this bug.