Bug 152512 - FTL B3 does not logicalNot correctly
Summary: FTL B3 does not logicalNot correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency treegraph
 
Reported: 2015-12-22 13:37 PST by Filip Pizlo
Modified: 2015-12-22 14:00 PST (History)
14 users (show)

See Also:


Attachments
the patch (28.77 KB, patch)
2015-12-22 13:42 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (29.89 KB, patch)
2015-12-22 13:44 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-12-22 13:37:20 PST
It was doing bitNot, which for a 32-bit integer means that 1 turns into -2 and 0 turns into -1, both of which evaluate true.
Comment 1 Filip Pizlo 2015-12-22 13:42:03 PST
Created attachment 267803 [details]
the patch
Comment 2 WebKit Commit Bot 2015-12-22 13:42:51 PST
Attachment 267803 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3Procedure.h:72:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLState.cpp:77:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2015-12-22 13:44:01 PST
Created attachment 267804 [details]
the patch
Comment 4 WebKit Commit Bot 2015-12-22 13:45:29 PST
Attachment 267804 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3Procedure.h:72:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLState.cpp:77:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Saam Barati 2015-12-22 13:49:55 PST
Comment on attachment 267803 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267803&action=review

r=me

> Source/JavaScriptCore/dfg/DFGCommon.h:41
> +#define FTL_USES_B3 1

revert
Comment 6 Filip Pizlo 2015-12-22 14:00:51 PST
Landed in http://trac.webkit.org/changeset/194372