Bug 152507 - Botwatcher's dashboard should show an 'X' when the build is broken
Summary: Botwatcher's dashboard should show an 'X' when the build is broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Burkart
Keywords: InRadar
Depends on:
Reported: 2015-12-22 12:20 PST by Dana Burkart
Modified: 2016-01-20 11:31 PST (History)
3 users (show)

See Also:

patch (2.37 KB, patch)
2015-12-22 12:24 PST, Dana Burkart
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Burkart 2015-12-22 12:20:56 PST
Currently, the botwatcher's dashboard only turns red (and still shows the issue count) when the build fails.
We should differentiate this failure case further from simply finding issues by displaying an 'X' instead of
an issue count.
Comment 1 Dana Burkart 2015-12-22 12:21:12 PST
Comment 2 Dana Burkart 2015-12-22 12:24:10 PST
Created attachment 267794 [details]

This fixes it so that we pass "null" to StatusLineView (in which case, an 'X' is displayed) if the build is broken.
Comment 3 David Kilzer (:ddkilzer) 2015-12-22 15:25:24 PST
Comment on attachment 267794 [details]

Comment 4 Dana Burkart 2016-01-20 11:31:17 PST
Committed r195359.