RESOLVED FIXED 152507
Botwatcher's dashboard should show an 'X' when the build is broken 
https://bugs.webkit.org/show_bug.cgi?id=152507
Summary Botwatcher's dashboard should show an 'X' when the build is broken
Dana Burkart
Reported 2015-12-22 12:20:56 PST
Currently, the botwatcher's dashboard only turns red (and still shows the issue count) when the build fails. We should differentiate this failure case further from simply finding issues by displaying an 'X' instead of an issue count.
Attachments
patch (2.37 KB, patch)
2015-12-22 12:24 PST, Dana Burkart 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dana Burkart
Comment 1 2015-12-22 12:21:12 PST
rdar://problem/23731424
Dana Burkart
Comment 2 2015-12-22 12:24:10 PST
Created attachment 267794 [details] patch This fixes it so that we pass "null" to StatusLineView (in which case, an 'X' is displayed) if the build is broken.
David Kilzer (:ddkilzer)
Comment 3 2015-12-22 15:25:24 PST
Comment on attachment 267794 [details] patch r=me
Dana Burkart
Comment 4 2016-01-20 11:31:17 PST
Committed r195359.
Note You need to log in before you can comment on or make changes to this bug.