Bug 152500 – [GTK] media controls is always displayed when video has a text track

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Wonchul Lee]

The media controls show up even the video does not have 'controls' attribute. 
Chrome and old (2.4.5) Webkit does not display media controls with it.

test sample : http://www.kaizou.org/demos/video-text-track-demo/

[Wonchul Lee]

Created attachment 268953 [details]
Patch

[Michael Catanzaro]

Comment on attachment 268953 [details]
Patch

Thanks for this patch. The code changes look sane, but I think this needs to be committed with a layout test, unless there's some reason it would be hard to test.

[Wonchul Lee]

Created attachment 269254 [details]
Patch

[Wonchul Lee]

@Michael, thanks for reviewing it, I updated some layout test what checked media controls not displaying on video with text track without 'controls' attribute by default and showing media controls on fullscreen regardless of 'controls' attribute.

[Michael Catanzaro]

Comment on attachment 269254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269254&action=review

Thanks Wonchul. Let's just rephrase the English text a bit:

> LayoutTests/media/video-controls-no-display-with-text-track-expected.txt:1
> +Tests that not showing video controls with text track without controls attribute by default and displaying it when request fullscreen

How about: "Tests that video controls are not shown for videos with a text track when the controls attribute is not present, except when fullscreen."

[Wonchul Lee]

Created attachment 269671 [details]
Patch

[Wonchul Lee]

Thanks, I rephrased it as you mentioned.

[WebKit Commit Bot]

Comment on attachment 269671 [details]
Patch

Clearing flags on attachment: 269671

Committed r195511: <http://trac.webkit.org/changeset/195511>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.