Bug 152494 - FTL B3 should do tail calls
Summary: FTL B3 should do tail calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 151808
  Show dependency tree / graph
 
Reported: 2015-12-21 17:30 PST by Filip Pizlo
Modified: 2015-12-22 12:03 PST (History)
12 users (show)

See Also:

Attachments
work in progress (8.64 KB, patch)
2015-12-21 17:31 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (10.89 KB, patch)
2015-12-22 11:27 PST, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
pathc for landing (10.88 KB, patch)
2015-12-22 11:38 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-12-21 17:30:00 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-12-21 17:31:31 PST 
Created attachment 267768 [details]
work in progress
Comment 2 Filip Pizlo 2015-12-22 11:27:41 PST 
Created attachment 267792 [details]
the patch
Comment 3 WebKit Commit Bot 2015-12-22 11:28:51 PST 
Attachment 267792 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5077:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5117:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Michael Saboff 2015-12-22 11:32:13 PST 
Comment on attachment 267792 [details]
the patch

r=me
Comment 5 Filip Pizlo 2015-12-22 11:37:30 PST 
(In reply to comment #4)
> Comment on attachment 267792 [details]
> the patch
> 
> r=me

Thanks!  I'll fix the build and land.
Comment 6 Filip Pizlo 2015-12-22 11:38:18 PST 
Created attachment 267793 [details]
pathc for landing
Comment 7 WebKit Commit Bot 2015-12-22 11:39:33 PST 
Attachment 267793 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5077:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5117:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2015-12-22 12:03:51 PST 
Landed in http://trac.webkit.org/changeset/194368