RESOLVED FIXED 152474
Web Inspector: Remove unused WebInspector.Object.removeAllListeners 
https://bugs.webkit.org/show_bug.cgi?id=152474
Summary Web Inspector: Remove unused WebInspector.Object.removeAllListeners
Nikita Vasilyev
Reported 2015-12-21 02:21:15 PST
WebInspector.Object.removeAllListeners is a dead code.
Attachments
Patch (3.56 KB, patch)
2015-12-21 02:44 PST, Nikita Vasilyev 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-yosemite (854.73 KB, application/zip)
2015-12-21 03:34 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.02 MB, application/zip)
2015-12-21 03:36 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews113 for mac-yosemite (898.15 KB, application/zip)
2015-12-21 03:42 PST, Build Bot 		no flags
Details
Patch (1.94 KB, patch)
2015-12-21 04:45 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2015-12-21 02:43:47 PST
More unused methods: * singleFireEventListener * retainedObjectsWithPrototype These two were added in http://trac.webkit.org/changeset/188756 for testing. No tests use these methods any longer - I searched with using: OpenSource$ ack -Q --js singleFireEventListener * hasEventListeners
Nikita Vasilyev
Comment 2 2015-12-21 02:44:38 PST
Created attachment 267738 [details] Patch
Build Bot
Comment 3 2015-12-21 03:34:13 PST
Comment on attachment 267738 [details] Patch Attachment 267738 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/588362 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-events-inspector-stylesheet.html inspector/unit-tests/event-listener-set.html inspector/css/stylesheet-events-basic.html inspector/css/stylesheet-events-multiple-documents.html inspector/console/clearMessages.html inspector/console/command-line-api.html inspector/console/messagesCleared.html inspector/model/scope-chain-node.html inspector/model/stack-trace.html http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html inspector/console/messageRepeatCountUpdated.html inspector/network/client-blocked-load.html inspector/unit-tests/event-listener.html
Build Bot
Comment 4 2015-12-21 03:34:16 PST
Created attachment 267740 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2015-12-21 03:36:52 PST
Comment on attachment 267738 [details] Patch Attachment 267738 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/588364 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-events-inspector-stylesheet.html inspector/unit-tests/event-listener-set.html inspector/css/stylesheet-events-basic.html inspector/css/stylesheet-events-multiple-documents.html inspector/console/clearMessages.html inspector/console/command-line-api.html inspector/console/messagesCleared.html inspector/model/scope-chain-node.html inspector/model/stack-trace.html http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html inspector/console/messageRepeatCountUpdated.html inspector/network/client-blocked-load.html inspector/unit-tests/event-listener.html
Build Bot
Comment 6 2015-12-21 03:36:56 PST
Created attachment 267741 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2015-12-21 03:42:38 PST
Comment on attachment 267738 [details] Patch Attachment 267738 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/588361 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-events-inspector-stylesheet.html inspector/unit-tests/event-listener-set.html inspector/css/stylesheet-events-basic.html inspector/css/stylesheet-events-multiple-documents.html inspector/console/clearMessages.html inspector/console/command-line-api.html inspector/console/messagesCleared.html inspector/model/scope-chain-node.html inspector/model/stack-trace.html http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html inspector/console/messageRepeatCountUpdated.html inspector/network/client-blocked-load.html inspector/unit-tests/event-listener.html
Build Bot
Comment 8 2015-12-21 03:42:40 PST
Created attachment 267742 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Nikita Vasilyev
Comment 9 2015-12-21 04:40:02 PST
singleFireEventListener, retainedObjectsWithPrototype, and hasEventListeners are used in inline scripts in HTML test files.
Nikita Vasilyev
Comment 10 2015-12-21 04:45:06 PST
Created attachment 267744 [details] Patch
WebKit Commit Bot
Comment 11 2015-12-21 17:42:33 PST
Comment on attachment 267744 [details] Patch Clearing flags on attachment: 267744 Committed r194356: <http://trac.webkit.org/changeset/194356>
WebKit Commit Bot
Comment 12 2015-12-21 17:42:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.