The first output printed by 'webkit-patch upload' is always these annoying warnings: /home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/keyring/backends/Gnome.py:6: PyGIWarning: GnomeKeyring was imported without specifying a version first. Use gi.require_version('GnomeKeyring', '1.0') before import to ensure that the right version gets loaded. from gi.repository import GnomeKeyring /home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/keyring/backends/Gnome.py:6: PyGIWarning: GnomeKeyring was imported without specifying a version first. Use gi.require_version('GnomeKeyring', '1.0') before import to ensure that the right version gets loaded. from gi.repository import GnomeKeyring
I spent a small amount of time trying to find a quick fix. It's already fixed upstream, so we just have to update the keyring module to 5.7.1. So I updated the definition of _install_keyring in Tools/Scripts/webkitpy/thirdparty: def _install_keyring(self): self._install("http://pypi.python.org/packages/source/k/keyring/keyring-5.7.1.tar.gz#md5=c1e0e5f00686f0ed118573ff47dfbaf8", "keyring") But I got this error: $ rm -rf Tools/Scripts/webkitpy/thirdparty/autoinstalled $ webkit-patch upload Traceback (most recent call last): File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkit-patch", line 44, in <module> from webkitpy.tool.main import WebKitPatch File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/tool/main.py", line 37, in <module> from webkitpy.common.host import Host File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/host.py", line 37, in <module> from webkitpy.common.net import bugzilla, buildbot, web File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py", line 4, in <module> from .bugzilla import Bugzilla File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 48, in <module> from webkitpy.common.net.credentials import Credentials File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/net/credentials.py", line 40, in <module> from webkitpy.thirdparty.autoinstalled import keyring File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 93, in find_module self._install_keyring() File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 103, in _install_keyring "keyring") File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 160, in _install installer.install(url=url, url_subpath=url_subpath, target_name=target_name) File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/system/autoinstall.py", line 515, in install raise Exception(message) Exception: Error auto-installing the keyring package to: "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/keyring" --> Inner message: [Errno 2] No such file or directory: '/tmp/keyring_tFSQ4h/keyring-5.7.1/keyring' Have not investigated further. The 4.0 package installs just fine.
Created attachment 289844 [details] Patch
Comment on attachment 289844 [details] Patch Hm, this upgrade breaks password storage. :S
Created attachment 289856 [details] Patch
Comment on attachment 289856 [details] Patch Clearing flags on attachment: 289856 Committed r206420: <http://trac.webkit.org/changeset/206420>
All reviewed patches have been landed. Closing bug.