Patch forthcoming.
Created attachment 267723 [details] it begins
Created attachment 267727 [details] a bit more
Created attachment 267728 [details] almost done
Created attachment 267737 [details] it compiles
Created attachment 267754 [details] it seems to work
Attachment 267754 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5227: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5233: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5322: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 267754 [details] it seems to work View in context: https://bugs.webkit.org/attachment.cgi?id=267754&action=review I am not familiar with the JS calling convention but nothing looks crazy here. > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5112 > + // different register for the late for the post-clobbering version of the value. This gives > + // the compiler to spill these values without having to burn any callee-saves. "to spill"->"a chance to spill"?
(In reply to comment #7) > Comment on attachment 267754 [details] > it seems to work > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267754&action=review > > I am not familiar with the JS calling convention but nothing looks crazy > here. > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5112 > > + // different register for the late for the post-clobbering version of the value. This gives > > + // the compiler to spill these values without having to burn any callee-saves. > > "to spill"->"a chance to spill"? Yeah, that's what I meant!
Landed in http://trac.webkit.org/changeset/194334
(In reply to comment #9) > Landed in http://trac.webkit.org/changeset/194334 It broke the EFL build: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/26013 ../../Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp: In member function ‘void JSC::FTL::{anonymous}::LowerDFGToLLVM::compileCallOrConstructVarargs()’: ../../Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5084:14: error: variable ‘forwarding’ set but not used [-Werror=unused-but-set-variable] bool forwarding = false;
Fix landed in https://trac.webkit.org/changeset/194347
(In reply to comment #11) > Fix landed in https://trac.webkit.org/changeset/194347 Thanks!