Bug 152463 - [CF] Replace CFNetwork-related WebKitSystemInterface calls with SPI
Summary: [CF] Replace CFNetwork-related WebKitSystemInterface calls with SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-19 19:42 PST by Andy Estes
Modified: 2016-01-04 11:52 PST (History)
9 users (show)

See Also:

Attachments
Patch (98.12 KB, patch)
2015-12-19 20:22 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (102.63 KB, patch)
2015-12-19 21:58 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (102.63 KB, patch)
2015-12-19 22:01 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (103.37 KB, patch)
2015-12-22 12:41 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (103.46 KB, patch)
2015-12-22 14:16 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-12-19 19:42:21 PST 
[CF] Replace CFNetwork-related WebKitSystemInterface calls with SPI
Comment 1 Andy Estes 2015-12-19 20:22:34 PST 
Created attachment 267707 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-12-19 20:32:59 PST 
Comment on attachment 267707 [details]
Patch

Looks good, although fixing all the builds may be challenging.
Comment 3 WebKit Commit Bot 2015-12-19 21:24:37 PST 
Comment on attachment 267707 [details]
Patch

Rejecting attachment 267707 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/spi/cf/CFNetworkSPI.h:134:36: note: 'CFURLCredentialStorageCreate' declared here
EXTERN_C CFURLCredentialStorageRef CFURLCredentialStorageCreate(CFAllocatorRef);
                                   ^

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/CookieJarMac.o platform/network/mac/CookieJarMac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/582707
Comment 4 Andy Estes 2015-12-19 21:58:25 PST 
Created attachment 267708 [details]
Patch
Comment 5 Andy Estes 2015-12-19 22:01:07 PST 
Created attachment 267709 [details]
Patch
Comment 6 Andy Estes 2015-12-22 12:41:38 PST 
Created attachment 267797 [details]
Patch
Comment 7 Andy Estes 2015-12-22 14:16:16 PST 
Created attachment 267806 [details]
Patch
Comment 8 WebKit Commit Bot 2015-12-22 15:52:25 PST 
Comment on attachment 267806 [details]
Patch

Clearing flags on attachment: 267806

Committed r194378: <http://trac.webkit.org/changeset/194378>
Comment 9 WebKit Commit Bot 2015-12-22 15:52:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Csaba Osztrogonác 2015-12-23 04:34:10 PST 
(In reply to comment #8)
> Comment on attachment 267806 [details]
> Patch
> 
> Clearing flags on attachment: 267806
> 
> Committed r194378: <http://trac.webkit.org/changeset/194378>

It broke the Apple Mac cmake build:
https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1224
Comment 11 Andy Estes 2015-12-25 00:09:58 PST 
(In reply to comment #10)
> (In reply to comment #8)
> > Comment on attachment 267806 [details]
> > Patch
> > 
> > Clearing flags on attachment: 267806
> > 
> > Committed r194378: <http://trac.webkit.org/changeset/194378>
> 
> It broke the Apple Mac cmake build:
> https://build.webkit.org/builders/
> Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1224

I'm not sure how to fix this. I noticed that the WebCore.framework created by CMake is missing the Headers or PrivateHeaders directories, so I'm not sure how WebKit is supposed to find WebCore external headers.

Alex, can you help?
Comment 12 Alex Christensen 2016-01-04 11:52:07 PST 
r194545 should fix that.