RESOLVED FIXED 152453
Add unary operator tests to compare JIT and LLINT results.
https://bugs.webkit.org/show_bug.cgi?id=152453
Summary Add unary operator tests to compare JIT and LLINT results.
Mark Lam
Reported 2015-12-18 17:09:31 PST
Patch coming.
Attachments
proposed patch. (15.76 KB, patch)
2015-12-18 17:18 PST, Mark Lam
benjamin: review+
Mark Lam
Comment 1 2015-12-18 17:18:31 PST
Created attachment 267665 [details] proposed patch.
Benjamin Poulain
Comment 2 2015-12-21 10:31:27 PST
Comment on attachment 267665 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=267665&action=review > Source/JavaScriptCore/tests/stress/resources/unary-op-test.js:5 > +// from permutations of operand value pairs. For each test, it computes the expected "using from permutations"?
Mark Lam
Comment 3 2015-12-21 10:37:22 PST
(In reply to comment #2) > Comment on attachment 267665 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267665&action=review > > > Source/JavaScriptCore/tests/stress/resources/unary-op-test.js:5 > > +// from permutations of operand value pairs. For each test, it computes the expected > > "using from permutations"? Sorry. That's a stale comment that was partially edited. I've fixed it to say "It works by generating test functions to exercise the specified operator on operand values in a provided set."
Mark Lam
Comment 4 2015-12-21 10:42:06 PST
Thanks for the review. Landed in r194333: <http://trac.webkit.org/r194333>.
Note You need to log in before you can comment on or make changes to this bug.