Bug 152450 - BytecodeGenerator::pushLexicalScopeInternal and pushLexicalScope should use enums instead of bools
Summary: BytecodeGenerator::pushLexicalScopeInternal and pushLexicalScope should use e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-18 15:53 PST by Saam Barati
Modified: 2015-12-18 16:20 PST (History)
6 users (show)

See Also:

Attachments
patch (12.43 KB, patch)
2015-12-18 16:08 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (12.66 KB, patch)
2015-12-18 16:10 PST, Saam Barati 		ggaren: review+
Details | Formatted Diff | Diff
patch (12.74 KB, patch)
2015-12-18 16:11 PST, Saam Barati 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-12-18 15:53:57 PST 
This will make the call sites easier to read.
Comment 1 Saam Barati 2015-12-18 16:08:15 PST 
Created attachment 267656 [details]
patch
Comment 2 Saam Barati 2015-12-18 16:10:19 PST 
Created attachment 267657 [details]
patch

hopefully this builds.
Comment 3 Geoffrey Garen 2015-12-18 16:11:00 PST 
r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:707
> +        enum class TDZCheckOptimization { CanOptimize, CanNotOptimize };

Technically, cannot is one word.

You could do Optimize / DoNotOptimize.
Comment 4 Saam Barati 2015-12-18 16:11:46 PST 
Created attachment 267658 [details]
patch

nope, it doesn't.
Maybe this time?
Comment 5 Saam Barati 2015-12-18 16:12:39 PST 
(In reply to comment #3)
> r=me
> 
> > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:707
> > +        enum class TDZCheckOptimization { CanOptimize, CanNotOptimize };
> 
> Technically, cannot is one word.
> 
> You could do Optimize / DoNotOptimize.

I'll do that.
Comment 6 Joseph Pecoraro 2015-12-18 16:16:30 PST 
Comment on attachment 267658 [details]
patch

r=me
Comment 7 Saam Barati 2015-12-18 16:20:30 PST 
landed in
http://trac.webkit.org/changeset/194304