Bug 152406 - We should have different JSTypes for JSGlobalLexicalEnvironment and JSLexicalEnvironment and JSModuleEnvironment
Summary: We should have different JSTypes for JSGlobalLexicalEnvironment and JSLexical...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-17 16:30 PST by Saam Barati
Modified: 2016-03-15 13:42 PDT (History)
10 users (show)

See Also:


Attachments
patch (12.99 KB, patch)
2015-12-18 17:15 PST, Saam Barati
no flags Details | Formatted Diff | Diff
patch (13.02 KB, patch)
2015-12-18 17:17 PST, Saam Barati
mark.lam: review+
Details | Formatted Diff | Diff
patch (21.61 KB, patch)
2016-03-15 11:59 PDT, Saam Barati
mark.lam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-yosemite (853.41 KB, application/zip)
2016-03-15 13:08 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-12-17 16:30:08 PST
This will give us a faster way of determining a JSLexicalEnvironment.
Comment 1 Saam Barati 2015-12-18 17:15:55 PST
Created attachment 267663 [details]
patch
Comment 2 Saam Barati 2015-12-18 17:17:26 PST
Created attachment 267664 [details]
patch

build fix.
Comment 3 Mark Lam 2015-12-18 17:23:44 PST
Comment on attachment 267664 [details]
patch

r=me if it builds and tests pass.
Comment 4 Saam Barati 2016-01-03 16:39:13 PST
Some module-related tests failed. I'll look into this tomorrow.
Comment 5 Saam Barati 2016-03-14 17:12:30 PDT
I'm going to look into this again.
Comment 6 Saam Barati 2016-03-15 11:59:55 PDT
Created attachment 274106 [details]
patch

up for review again because it's been a while
Comment 7 Mark Lam 2016-03-15 12:17:25 PDT
Comment on attachment 274106 [details]
patch

r=me
Comment 8 Build Bot 2016-03-15 13:08:29 PDT
Comment on attachment 274106 [details]
patch

Attachment 274106 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/984666

New failing tests:
js/function-call-aliased.html
Comment 9 Build Bot 2016-03-15 13:08:32 PDT
Created attachment 274117 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Saam Barati 2016-03-15 13:42:23 PDT
landed in:
http://trac.webkit.org/changeset/198228