Bug 152402 - Web Inspector: improve pre-filled bugzilla link on Uncaught Exception reporter sheet
Summary: Web Inspector: improve pre-filled bugzilla link on Uncaught Exception reporte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-17 15:38 PST by BJ Burg
Modified: 2015-12-27 19:01 PST (History)
7 users (show)

See Also:


Attachments
Proposed Fix (3.48 KB, patch)
2015-12-17 16:01 PST, BJ Burg
joepeck: review+
bburg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-12-17 15:38:44 PST
- Include the inspected page URL
 - Include a better bug template
Comment 1 BJ Burg 2015-12-17 16:01:39 PST
Created attachment 267592 [details]
Proposed Fix
Comment 2 BJ Burg 2015-12-17 16:04:05 PST
New pre-filled bugzilla description looks like:

-------
Auto-generated details:

Inspected URL:        https://www.mozilla.org/en-US/firefox/new/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/602.1.15+ (KHTML, like Gecko)
Uncaught exceptions:
 - TypeError: InspectorFrontendHost.zoomFactor is not a function. (In 'InspectorFrontendHost.zoomFactor()', 'InspectorFrontendHost.zoomFactor' is an instance of Object) (at Main.js:1907:55)
-------

* STEPS TO REPRODUCE
1. What were you doing? Include setup or other preparations to reproduce the exception.
2. Include explicit, accurate, and minimal steps taken. Do not include extraneous or irrelevant steps.

* NOTES
Document any additional information that might be useful in resolving the problem, such as screen shots or other included attachments.
Comment 3 Joseph Pecoraro 2015-12-17 16:29:44 PST
Comment on attachment 267592 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267592&action=review

r=me

> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:150
> +Loading completed:    ${loadCompleted ? "true" : "false"}

This can just be ${!!loadCompleted}. The boolean will stringily as expected.

> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:151
> +Frontend User Agent:  ${window.navigator.userAgent}

I'm not sure the user agent gives much value.
Comment 4 Timothy Hatcher 2015-12-17 19:21:48 PST
Comment on attachment 267592 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267592&action=review

>> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:151
>> +Frontend User Agent:  ${window.navigator.userAgent}
> 
> I'm not sure the user agent gives much value.

It lets us know the Safari/WebKit version. Though window.navigator.appVersion is likely better as it leave out some of the cruft.
Comment 5 Radar WebKit Bug Importer 2015-12-27 14:55:00 PST
<rdar://problem/24012866>
Comment 6 BJ Burg 2015-12-27 19:01:28 PST
Committed r194427: <http://trac.webkit.org/changeset/194427>