WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
152402
Web Inspector: improve pre-filled bugzilla link on Uncaught Exception reporter sheet
https://bugs.webkit.org/show_bug.cgi?id=152402
Summary
Web Inspector: improve pre-filled bugzilla link on Uncaught Exception reporte...
Blaze Burg
Reported
2015-12-17 15:38:44 PST
- Include the inspected page URL - Include a better bug template
Attachments
Proposed Fix
(3.48 KB, patch)
2015-12-17 16:01 PST
,
Blaze Burg
joepeck
: review+
bburg
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Blaze Burg
Comment 1
2015-12-17 16:01:39 PST
Created
attachment 267592
[details]
Proposed Fix
Blaze Burg
Comment 2
2015-12-17 16:04:05 PST
New pre-filled bugzilla description looks like: ------- Auto-generated details: Inspected URL:
https://www.mozilla.org/en-US/firefox/new/
Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/602.1.15+ (KHTML, like Gecko) Uncaught exceptions: - TypeError: InspectorFrontendHost.zoomFactor is not a function. (In 'InspectorFrontendHost.zoomFactor()', 'InspectorFrontendHost.zoomFactor' is an instance of Object) (at Main.js:1907:55) ------- * STEPS TO REPRODUCE 1. What were you doing? Include setup or other preparations to reproduce the exception. 2. Include explicit, accurate, and minimal steps taken. Do not include extraneous or irrelevant steps. * NOTES Document any additional information that might be useful in resolving the problem, such as screen shots or other included attachments.
Joseph Pecoraro
Comment 3
2015-12-17 16:29:44 PST
Comment on
attachment 267592
[details]
Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=267592&action=review
r=me
> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:150 > +Loading completed: ${loadCompleted ? "true" : "false"}
This can just be ${!!loadCompleted}. The boolean will stringily as expected.
> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:151 > +Frontend User Agent: ${window.navigator.userAgent}
I'm not sure the user agent gives much value.
Timothy Hatcher
Comment 4
2015-12-17 19:21:48 PST
Comment on
attachment 267592
[details]
Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=267592&action=review
>> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:151 >> +Frontend User Agent: ${window.navigator.userAgent} > > I'm not sure the user agent gives much value.
It lets us know the Safari/WebKit version. Though window.navigator.appVersion is likely better as it leave out some of the cruft.
Radar WebKit Bug Importer
Comment 5
2015-12-27 14:55:00 PST
<
rdar://problem/24012866
>
Blaze Burg
Comment 6
2015-12-27 19:01:28 PST
Committed
r194427
: <
http://trac.webkit.org/changeset/194427
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug